Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't ask me again in Google Translate doorhanger panel is missing its checkbox #14767

Open
stephendonner opened this issue Mar 16, 2021 · 1 comment
Labels
accessibility bug OS/Desktop priority/P4 Planned work. We expect to get to it "soon". regression

Comments

@stephendonner
Copy link

Description

Don't ask me again in Google Translate doorhanger panel is missing its checkbox

Steps to Reproduce

  1. new profile on nightly
  2. load https://pgl.yoyo.org/adservers/serverlist.php?hostformat=adblockplus&showintro=1&mimetype=plaintext
  3. look at the doorhanger panel which drops down from the URL bar

Actual result:

Screen Shot 2021-03-16 at 1 58 20 PM

Expected result:

I'd expect there to be a checkbox to the left of the Don't ask me again text (compare with the Widevine prompt, below)

Screen Shot 2021-03-16 at 1 58 52 PM

And, like the Widevine prompt, it should also be:

  1. keyboard-accessible (tab with focus rings, spacebar to select and deselect checkbox/option) - cross-reference: Tab and spacebar keyboard-accessibility don't work on Widevine panel #14578
  2. text-consistent (Don't ask me again here, vs. Don't ask again in Widevine prompt)

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.23.41 Chromium: 89.0.4389.90 (Official Build) nightly (x86_64)
Revision 62eb262cdaae9ef819aadd778193781455ec7a49-refs/branch-heads/4389@{#1534}
OS macOS Version 11.2.3 (Build 20D91)

cc: @karenkliu @rebron

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes
@rebron
Copy link
Collaborator

rebron commented Mar 19, 2021

cc: @yrliou When you get a chance can you take a look?

@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility bug OS/Desktop priority/P4 Planned work. We expect to get to it "soon". regression
Projects
None yet
Development

No branches or pull requests

2 participants