Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White background causes issues with top site icons #14929

Closed
iam-cult opened this issue Mar 24, 2021 · 1 comment
Closed

White background causes issues with top site icons #14929

iam-cult opened this issue Mar 24, 2021 · 1 comment
Labels
closed/duplicate Issue has already been reported OS/Desktop

Comments

@iam-cult
Copy link

Description

Some websites have favicons that inherit the browser's theme, so that they are easy to see. However, since top sites use the favicons of webpages, and top sites have a white background, sites which use white favicons to look good in a dark theme (namely GitHub), just appear as a white square.

Steps to Reproduce

  1. Visit GitHub enough to get it into your top sites/Add it manually in Brave Beta
  2. Notice that the icon is the exact same color as the background
  3. Be confused every time you open a new tab and go to open GitHub

Actual result:

Screen Shot 2021-03-24 at 15 24 42

Expected result:

The background of top sites could change with the browser theme, the background could be gray, or you could have the option to provide custom icons

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave: 1.23.48 Chromium: 89.0.4389.90 (Official Build) beta (x86_64)
Revision: 62eb262cdaae9ef819aadd778193781455ec7a49-refs/branch-heads/4389@{#1534}
OS: macOS Version 11.3 (Build 20E5210c)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
    Yes
  • Can you reproduce this issue with the beta channel?
    Yes
  • Can you reproduce this issue with the nightly channel?
    Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
    No
  • Does the issue resolve itself when disabling Brave Rewards?
    No
  • Is the issue reproducible on the latest version of Chrome?
    N/A

Miscellaneous Information:

@bsclifton
Copy link
Member

Closing as this issue is a duplicate of #14453

The good news: this was recently fixed by @simonhong with brave/brave-core#8339 😄 The fix will be in the next Nightly build and will work its way through the channels

@bsclifton bsclifton added the closed/duplicate Issue has already been reported label Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported OS/Desktop
Projects
None yet
Development

No branches or pull requests

2 participants