Bump Brave's Windows updater (Omaha) to v1.3.361.113 #22060

mherrmann · 2022-04-04T06:36:20Z

Description

We want to disable some statistics collection in Brave's auto-updater on Windows. We're taking this as an opportunity to make a few other small improvements to the auto-updater. Specifically:

This issue should count as resolved once stats collection no longer occurs as described in brave/omaha#41 and most of Brave's auto-update fleet on Windows uses the new updater version.

mherrmann · 2022-04-05T07:16:43Z

Re-opening as I've had to roll back #12868 in brave/brave-core#12874.

LaurenWags · 2022-04-28T16:36:48Z

@brave/legacy_qa we should check Win 10 and 11 at a minimum. Win 8 and 7 would be helpful, but not strictly necessary.

Update - based on further discussions, we're going to execute full checks on Win 10 and 11 x64. We're going to do targeted cases on Win 8 x86, Win 7, Win 10 x86.

GeetaSarvadnya · 2022-05-06T11:59:38Z

Verification PASSED on


Brave | 1.39.92 Chromium: 101.0.4951.54 (Official Build) beta (64-bit)
-- | --
Revision | 67da1aeb32cedd27634ca6634fb79cbd85d3f0ab-refs/branch-heads/4951@{#1126}
OS | Windows 10 Version 21H2 (Build 19044.1645)

Verified the test plan from Bump the Windows updater (Omaha) to v1.3.361.113 brave-core#12895

Windows 10 x64

1. Verify installers and auto-updater work on a clean profile

Case 1: Verify the Omaha updater version when 1.39.x is installed_PASSED

Pre-requisites:
(Please note these steps are same as remove updater as described in the "Cleaning up after a test" in brave/brave-core#11096 but I have breakdown the steps into detailed)

Uninstall all the brave version (all channels Dev, Release, Beta and Nightly) via Control panel
Remove all the local profile folders from %LOCALAPPDATA%\BraveSoftware
Go to C:\Program Files (x86)\BraveSoftware\update path and observe that Update folder is still available and updater version 1.3.361.113 is still shown
Open RegEdit and navigate to Computer\HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\Update and ensure Omaha updater version is 1.3.361.113
Open command prompt with Admin privileges and run the command "C:\Program Files (x86)\BraveSoftware\Update\BraveUpdate.exe" /uninstall
Go to C:\Program Files (x86)\BraveSoftware path and observe that the update folder is removed
Open RegEdit and navigate to Computer\HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\Update and ensure Omaha updater version 1.3.361.113 is removed from the registry
If the registry key isn't empty in steps 6 and 7 then kill all instances of BraveUpdate.exe, BraveCrashHandler.exe, BraveCrashHandler64.exe in the Task Manager
Steps 6 and 7 indicate that the Omaha updater is completely uninstalled

Steps:

Run the steps 1 to 7 from Pre-requisites
Download BraveBrowserStandaloneBetaSetup.exe and install the standalone binary 1.39.x with Admin rights and ensured that standalone installer installed successfully
Confirmed that the new Omaha updater 1.3.361.113 is shown in the registry as expected
Confirmed new Omaha updater version 1.3.361.113 is shown in C:\Program Files (x86)\BraveSoftware\Update
Uninstall the 1.39.x from control panel and remove the profile folder from the %LOCALAPPDATA%\BraveSoftware
Install the 1.39.x again and confirmed that the brave installed successfully
Go to brave://settings/help and wait for the update and and click on the Relaunch and confirmed that brave is upgraded to latest public version

Example	Example	Example	Example

Case 2: Download and install stub installer binary 1.39.x with Admin rights_PASSED

Uninstall 1.39.x from the control panel if it's installed
Remove local profile folders from %LOCALAPPDATA%\BraveSoftware
Install 1.39.x stub installer BraveBrowserBetaSetup.exe and ensured that brave is installed successfully and latest public released beta version is fetched from the Omaha server as expected

Case 3: Download and install standalone silent installer binary 1.39.x_PASSED

Uninstall 1.39.x from the control panel if it's installed
Remove local profile folders from %LOCALAPPDATA%\BraveSoftware
Install 1.39.x standalone silent installer BraveBrowserStandaloneSilentBetaSetup.exe and ensured that brave is installed in silent mode (Installer modal is NOT shown on the UI) and ensured that correct version details are shown brave://settings/help

2. Verify installers and auto-updater works on upgrade profile

Case 1:Verify the Omaha updater version in an upgraded profile (Install 1.34.60 ->upgrade to 1.39.x)_PASSED

Steps :

Follow the pre-requisites steps from case 1 to uninstall the Omaha
Install the BraveBrowserStandaloneBetaSetup.exe build version1.34.60 (build before the Omaha updater change 1.3.361.113)
Confirmed build is installed successfully and version details are shown correctly in brave://settings/help
Confirmed that the old Omaha updater 1.3.361.111 is shown in the registry as expected
Confirmed old Omaha updater version 1.3.361.111 is shown in C:\Program Files (x86)\BraveSoftware\Update
Go to brave://settings/help and wait for update and click on Relaunch and ensured brave is updated to the latest public beta version 1.39.x

1.34.60

Example	Example	Example	Example

Followed the steps from "Background updates" in brave/brave-core#11096 - to verify the Omaha updates silently in the background and confirmed that updater got updated to latest version 1.3.361.113 (followed the steps from #22060 (comment) also)

Case 2: Install standalone installer 1.38.x and upgrade the profile to 1.39.x_PASSED

Install standalone beta installer 1.38.x
Go to brave://settings/help and wait for the update and click on Relaunch
Confirmed that brave is upgraded to 1.39.x public released version

Case 3: Install standalone installer 1.38.x and upgrade the profile to 1.39.x test channel_PASSED

Install 1.38.x standalone beta installer
Confirmed brave 1.38.x installed successfully
Install the test channel BraveBrowserBetaSetup-64-be-test
Confirmed that brave is upgraded to 1.39.x test channel

Case 4: Install standalone silent installer 1.38.x and upgrade the profile to 1.39.x_PASSED

Install 1.38.x standalone silent beta installer
Go to brave://settings/help and wait for the update and click on Relaunch
Confirmed that brave is upgraded to 1.39.x public released version

3. Verify installers and auto-updater work when the user declines the Admin rights in UAC

[Note : when brave is installed for the current user (without admin rights) the Brave-Browser-Beta folder gets created under the registry path Computer\HKEY_CURRENT_USER\SOFTWARE\BraveSoftware\ and Omaha new updater version is shown as expected (detailed testing for the current user is covered in https://github.com//issues/22179#issuecomment-1112647799]

Case 1: Verify standalone installer can be installed without admin rights and updater works_PASSED

Install 1.39.x beta standalone installer
Decline the Admin rights in UAC while installing the setup
Confirmed 1.39.x beta standalone installer is installed successfully
Go to brave://settings/help and wait for the update and click on Relaunch
Confirmed that the brave is upgraded to 1.39.x beta public released version

Case 2: Verify stub installer can be installed without admin rights_PASSED

Install 1.39.x beta stub installer
Decline the Admin rights in UAC while installing the setup
Confirmed 1.39.x public released beta version is installed

4. Verify re-install same installer version works

Case 1: Verify standalone installer can be installed twice and update works_PASSED

Install 1.39.x standalone installer twice
Ensured two brave windows are opened with the same version
Go to brave://settings/help and wait for the update and click on Relaunch
Confirmed that brave is updated to 1.39.x public released version

Case 2: Verify stub installer can be installed twice_PASSED

Install 1.39.x stub installer twice
Ensured two brave windows are opened with the same version
Go to brave://settings/help and confirmed that the 1.39.x public release version is shown

Case 3: Verify standalone silent installer can be installed twice and update works_PASSED

Install 1.39.x standalone silent installer twice
Go to brave://settings/help and wait for the update and click on Relaunch
Confirmed that brave is updated to 1.39.x public released version

5. Install quite older installers and check update works correctly

Case 1: Install 1.30.x and ensure upgrade works_PASSED

Install 1.30.x beta build
Go to brave://settings/help and wait for update and click on Relaunch
Confirmed 1.39.x public released version is installed

1.30.x	1.39.x

Case 2: Install 1.34.x and ensure upgrade works_PASSED

Install 1.34.x beta build
Go to brave://settings/help and wait for the update and click on Relaunch
Confirmed 1.39.x public released version is installed

1.34.x	1.39.x

Case 3: Install 1.29.x and ensure upgrade works_PASSED

Install 1.29.x beta build
Go to brave://settings/help and wait for the update and click on Relaunch
Confirmed 1.39.x public released version is installed

1.29.x	1.39.x

Case 4: Install 1.22.x and ensure upgrade works_PASSED

Install 1.22.x beta build
Go to brave://settings/help and wait for the update and click on Relaunch
Confirmed 1.39.x public released version is installed

1.22.x	1.39.x

Case 5: Install 1.18.x and ensure upgrade works_PASSED

Install 1.22.x beta build
Go to brave://settings/help and wait for the update and click on Relaunch
Confirmed 1.39.x public released version is installed

1.18.x	1.39.x

6. Verify that install brave works when the Internet is disconnected

Case 1: Verify standalone installer can be installed when the network is disconnected_PASSED

Install 1.39.x standalone installer
Confirmed standalone installer is installed successfully and version details are shown correctly
Go to brave://settings/help and ensured update is NOT shown which is expected as to pull the Omaha version network needs to be connected

Case 2: Verify standalone silent installer can be installed when the network is disconnected_PASSED

Install 1.39.x standalone silent installer
Confirmed standalone silent installer is installed successfully and version details are shown correctly
Go to brave://settings/help and ensured update is NOT shown which is expected as to pull the Omaha version network needs to be connected

Case 3: Verify stub installer can't be installed when the network is disconnected_PASSED

Try installing the stub installer
Unable to install the installer which is expected as to pull the Omaha version network needs to be connected

7. Verify installing a new binary by older binary from different installers (e.g one is standalone and the other is stub/silent)

Case 1: Install standalone installer 1.38.x and upgrade it by 1.39.x stub installer_PASSED

Clean profile 1.38.x standalone installer BraveBrowserStandaloneSetup.exe
Install the standalone installer and confirmed 1.38.x is installed successfully
Upgrade the profile by 1.39.x stub installer BraveBrowserBetaSetup.exe
Confirmed that the 1.39.x public releases version is installed successfully

Case 2: Install standalone silent installer 1.38.x and upgrade it by 1.39.x stub installer(decline Admin rights)_PASSED

Clean profile 1.38.x standalone installer BraveBrowserStandaloneSilentBetaSetup.exe
Install the standalone silent installer and confirmed 1.38.x is installed successfully
Upgrade the profile by 1.39.x stub installer BraveBrowserBetaSetup.exe while installing decline the Admin rights
Go to brave://settings/help and click on Relaunch
Confirmed that the 1.39.x public releases version is installed successfully

Case 3: Install standalone silent installer 1.38.x and then autoupgrade_PASSED

Clean profile 1.38.x standalone silent installer BraveBrowserStandaloneSilentBetaSetup.exe
Go to brave://settings/help and wait for the update and click on Relaunch
Confirmed that the 1.39.x public releases version is installed successfully

Case 4: Install standalone installer 1.38.x and then autoupgrade_PASSED

Clean profile 1.38.x standalone installer BraveBrowserStandaloneBetaSetup.exe
Go to brave://settings/help and wait for the update and click on Relaunch
Confirmed that the 1.39.x public releases version is installed successfully

GeetaSarvadnya · 2022-05-10T13:52:06Z

QA/Blocked until the clarification gets resolved brave/brave-core#12895 (comment)

GeetaSarvadnya · 2022-05-11T14:06:12Z

@mherrmann Could you review the scenario please?

Follow the remove updater as described in the "Cleaning up after a test" in Rebase Omaha (=updater on Windows) to v1.3.36.111 brave-core#11096.
Install the BraveBrowserStandaloneBetaSetup.exe build version1.34.60 (build which is before the Omaha updater change 1.3.361.113)
Confirmed build is installed successfully and version details are shown correctly in brave://settings/help
Confirmed that the old Omaha updater 1.3.361.111 is shown in the registry as expected
Confirmed old Omaha updater version 1.3.361.111 is shown in C:\Program Files (x86)\BraveSoftware\Update
Go to brave://settings/help and wait for update and click on Relaunch and ensured brave is updated to the latest public beta version 1.39.x

@mherrmann Once the build is upgraded to 1.39.x beta, the Omaha updater version is still 1.3.361.111 in the registry, looks like it's expected as updater is using the old Omaha updater to perform the update. Just wanted to reconfirm is this expected?

mherrmann · 2022-05-11T14:10:16Z

@GeetaSarvadnya it might be OK. Do background updates update the updater to .113? Please see "Background updates" in brave/brave-core#11096 for the steps necessary to test this.

GeetaSarvadnya · 2022-05-12T10:55:42Z

@mherrmann: I ran BraveSoftwareUpdateTaskMachineUA task multiple times in windows task scheduler to check the brave background updates, but Omaha updater is not updating to the latest updater version .113 in an upgraded profile (1.34.x to -> 1.39.x) . The new updater isn't yet uploaded to the update server?

mherrmann · 2022-05-12T11:10:34Z

@GeetaSarvadnya this was my mistake. The new updater is not yet uploaded to the update server (otherwise, all users would already be receiving it).

I've uploaded the new updater to the staging update server. You can configure your machine to pull updates from staging by setting the registry string value Computer\HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\UpdateDev\url to https://updates.brave.com/service/update2. You need to be connected to VPN to be able to access the staging update server. (To test, you can open https://updates.brave.com. If you get a 404 error, then you have access.)

The above should let you update the updater to 1.3.361.113. If you encounter any issues, please just let me know.

GeetaSarvadnya · 2022-05-12T12:14:31Z

@mherrmann Brave background task scheduler update the Omaha updater to latest version .113. Thanks!

MadhaviSeelam · 2022-05-13T23:42:02Z

Verification PASSED using

Brave | 1.39.101 Chromium: 101.0.4951.64 (Official Build) beta (64-bit)
-- | --
Revision | d1daa9897e1bc1d507d6be8f2346e377e5505905-refs/branch-heads/4951@{#1208}
OS | Windows 11 Version 21H2 (Build 22000.675)

Verified the test plan from Bump the Windows updater (Omaha) to v1.3.361.113 brave-core#12895

Windows 11x64

1. Verify installers and auto-updater work on a clean profile

Case 1: Verify the Omaha updater version when 1.39.x is installed_PASSED

Pre-requisites:
(Please note these steps are same as remove updater as described in the "Cleaning up after a test" in brave/brave-core#11096 but I have breakdown the steps into detailed)

Uninstall all the brave version (all channels Dev, Release, Beta and Nightly) via Control panel
Remove all the local profile folders from %LOCALAPPDATA%\BraveSoftware
Go to C:\Program Files (x86)\BraveSoftware\update path and observe that Update folder is still available and updater version 1.3.361.113 is still shown
Open RegEdit and navigate to Computer\HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\Update and ensure Omaha updater version is 1.3.361.113
Open command prompt with Admin privileges and run the command "C:\Program Files (x86)\BraveSoftware\Update\BraveUpdate.exe" /uninstall
Go to C:\Program Files (x86)\BraveSoftware path and observe that the update folder is removed
Open RegEdit and navigate to Computer\HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\Update and ensure Omaha updater version 1.3.361.113 is removed from the registry
If the registry key isn't empty in steps 6 and 7 then kill all instances of BraveUpdate.exe, BraveCrashHandler.exe, BraveCrashHandler64.exe in the Task Manager
Steps 6 and 7 indicate that the Omaha updater is completely uninstalled''

Steps:

Run the steps 1 to 7 from Pre-requisites
Download BraveBrowserStandaloneBetaSetup.exe and install the standalone binary 1.39.x with Admin rights and ensured that standalone installer installed successfully
Confirmed that the new Omaha updater 1.3.361.113 is shown in the registry as expected
Confirmed new Omaha updater version 1.3.361.113 is shown in C:\Program Files (x86)\BraveSoftware\Update
Uninstall the 1.39.x from control panel and remove the profile folder from the %LOCALAPPDATA%\BraveSoftware
Install the 1.39.x again and confirmed that the brave installed successfully
Go to brave://settings/help and wait for the update and and click on the Relaunch and confirmed that brave is upgraded to latest public version

ex	ex	ex	ex

Case 2: Download and install stub installer binary 1.39.x with Admin rights_PASSED

Uninstall 1.39.x from the control panel if it's installed
Remove local profile folders from %LOCALAPPDATA%\BraveSoftware
Install 1.39.x stub installer BraveBrowserBetaSetup.exe and ensured that brave is installed successfully and latest public released beta version is fetched from the Omaha server as expected

Testcase 2-test stub installer -public beta

Case 3: Download and install standalone silent installer binary 1.39.x with out Admin rights_PASSED

Uninstall 1.39.x from the control panel if it's installed
Remove local profile folders from %LOCALAPPDATA%\BraveSoftware
Install 1.39.x standalone silent installer BraveBrowserStandaloneSilentBetaSetup.exe - (1.39.106 Chromium: 101.0.4951.67 (Official Build) beta)
Ensured that brave is installed in silent mode (Installer modal is NOT shown on the UI) and ensured that correct version details are shown brave://settings/help

ex1	ex2

2. Verify installers and auto-updater works on upgrade profile

Case 1:Verify the Omaha updater version in an upgraded profile (Install 1.34.60 ->upgrade to 1.39.x)_PASSED

Steps :

Follow the pre-requisites steps from case 1
Install the BraveBrowserStandaloneBetaSetup.exe build version1.34.60 (build before the Omaha updater change 1.3.361.113)
Confirmed build is installed successfully and version details are shown correctly in brave://settings/help
Confirmed that the old Omaha updater 1.3.361.111 is shown in the registry as expected
Confirmed old Omaha updater version 1.3.361.111 is shown in C:\Program Files (x86)\BraveSoftware\Update
Go to brave://settings/help and wait for update and click on Relaunch and ensured brave is updated to the latest public beta version 1.39.x

Ex1	Ex2	Ex3	Ex4	Ex5

Updater Validation

Followed the steps from "Background updates" in Rebase Omaha (=updater on Windows) to v1.3.36.111 brave-core#11096 - to verify the Omaha updates silently in the background and confirmed that updater got updated to latest version 1.3.361.113
Followed the steps from Bump Brave's Windows updater (Omaha) to v1.3.361.113 #22060 (comment) as well

1.3.361.113

RegEdit	Fiddler_Logs

Case 2: Install standalone installer 1.38.x and upgrade the profile to 1.40.x_PASSED

Install standalone beta installer 1.38.x
Go to brave://settings/help and wait for the update and click on Relaunch
Confirmed that brave is upgraded to 1.40.x public released version

1.34.60	1.40.68

Case 3: Install standalone installer 1.38.x and upgrade the profile to 1.40.x test channel_PASSED

Install 1.38.x standalone beta installer
Confirmed brave 1.38.x installed successfully
Install the test channel BraveBrowserBetaSetup-64-be-test
Confirmed that brave is upgraded to 1.40.x test channel

1.34.60	1.40.68

Case 4: Install standalone silent installer 1.38.x and upgrade the profile to 1.40.x_PASSED

Install 1.38.x standalone silent beta installer
Go to brave://settings/help and wait for the update and click on Relaunch
Confirmed that brave is upgraded to 1.40.x public released version

1.34.60	1.40.68

3. Verify installers and auto-updater work when the user declines the Admin rights in UAC
[Note : when brave is installed for the current user (without admin rights) the Brave-Browser-Beta folder gets created under the registry path Computer\HKEY_CURRENT_USER\SOFTWARE\BraveSoftware\ and Omaha new updater version is shown as expected (detailed testing for the current user is covered in https://github.com/https://github.com//issues/22179#issuecomment-1112647799]

Case 1: Verify standalone installer can be installed without admin rights and updater works_PASSED

Install 1.39.x beta standalone installer (Beta v1.39.104 (Chromium 101.0.4951.64)
Decline the Admin rights in UAC while installing the setup
Confirmed 1.39.x beta standalone installer is installed successfully
Go to brave://settings/help and wait for the update and click on Relaunch
Confirmed that the brave is upgraded to 1.39.x beta public released version

ex1	ex2	ex3

Case 2: Verify stub installer can be installed without admin rights_PASSED

Install 1.39.x beta stub installer (Beta v1.39.104 (Chromium 101.0.4951.64)
Decline the Admin rights in UAC while installing the setup
Confirmed 1.39.x public released beta version is installed (Beta v1.39.101 (Chromium 101.0.4951.64)

4. Verify re-install same installer version works

Case 1: Verify standalone installer can be installed twice and update works_PASSED

Install 1.39.x standalone installer twice (Beta v1.39.96 (Chromium 101.0.4951.54)
Ensured two brave windows are opened with the same version
Go to brave://settings/help and wait for the update and click on Relaunch
Confirmed that brave is updated to 1.39.x public released version

Ex1	Ex2

Case 2: Verify stub installer can be installed twice_PASSED

Install 1.39.x stub installer twice
Ensured two brave windows are opened with the same version
Go to brave://settings/help and confirmed that the 1.39.x public release version is shown

Case 3: Verify standalone silent installer can be installed twice and update works_PASSED

Install 1.39.x standalone silent installer twice
Go to brave://settings/help and wait for the update and click on Relaunch
Confirmed that brave is updated to 1.39.x public released version

Ex1	Ex2	Ex3
	<	<

5. Install quite older installers and check update works correctly

Case 1: Install 1.30.x and ensure upgrade works_PASSED

Install 1.30.x beta build
Go to brave://settings/help and wait for update and click on Relaunch
Confirmed 1.39.x public released version is installed

1.30.68	1.39.106	logs

Case 2: Install 1.34.x and ensure upgrade works_PASSED

Install 1.34.x beta build
Go to brave://settings/help and wait for the update and click on Relaunch
Confirmed 1.39.x public released version is installed

1.34.68	1.39.106	logs

Case 3: Install 1.29.x and ensure upgrade works_PASSED

Install 1.29.x beta build
Go to brave://settings/help and wait for the update and click on Relaunch
Confirmed 1.39.x public released version is installed

1.29.69	1.39.106	logs

Case 4: Install 1.22.x and ensure upgrade works_PASSED

Install 1.22.x beta build
Go to brave://settings/help and wait for the update and click on Relaunch
Confirmed 1.39.x public released version is installed

1.22.x	1.39.x	logs
		<

Case 5: Install 1.18.x and ensure upgrade works_PASSED

Install 1.18.x beta build
Go to brave://settings/help and wait for the update and click on Relaunch
Confirmed 1.39.x public released version is installed

1.18.67	1.39.106	Logs

6. Verify that install brave works when the Internet is disconnected

Case 1: Verify standalone installer can be installed when the network is disconnected_PASSED

Install 1.39.x standalone installer - BraveBrowserStandaloneBetaSetup
Confirmed standalone installer is installed successfully and version details are shown correctly
Go to brave://settings/help and ensured update is NOT shown which is expected as to pull the Omaha version network needs to be connected

Case 2: Verify standalone silent installer can be installed when the network is disconnected_PASSED

Install 1.39.x standalone silent installer - BraveBrowserStandaloneSilentBetaSetup
Confirmed standalone silent installer is installed successfully and version details are shown correctly
Go to brave://settings/help and ensured update is NOT shown which is expected as to pull the Omaha version network needs to be connected

Case 3: Verify stub installer can't be installed when the network is disconnected_PASSED

Try installing the stub installer (BraveBrowserBetaSetup) - (Beta v1.39.106 (Chromium 101.0.4951.67)
Unable to install the installer which is expected as to pull the Omaha version network needs to be connected

7. Verify installing a new binary by older binary from different installers (e.g one is standalone and the other is stub/silent)

Case 1: Install standalone installer 1.38.x and upgrade it by 1.39.x stub installer_PASSED

Clean profile 1.38.x standalone installer BraveBrowserStandaloneSetup.exe
Install the standalone installer and confirmed 1.38.x is installed successfully
Upgrade the profile by 1.39.x stub installer BraveBrowserBetaSetup.exe
Confirmed that the 1.39.x public releases version is installed successfully

1.38.88	1.39.106

Case 2: Install standalone silent installer 1.38.x and upgrade it by 1.39.x stub installer(decline Admin rights)_PASSED

Clean profile 1.38.x silent standalone installer BraveBrowserStandaloneSilentBetaSetup.exe
Install the standalone silent installer and confirmed 1.38.x is installed successfully
Upgrade the profile by 1.39.x stub installer BraveBrowserBetaSetup.exe while installing decline the Admin rights
Go to brave://settings/help and click on Relaunch
Confirmed that the 1.39.x public releases version is installed successfully

1.38.88	1.39.106

Case 3: Install standalone silent installer 1.38.x and then auto upgrade_PASSED

Clean profile 1.38.x standalone silent installer BraveBrowserStandaloneSilentBetaSetup.exe
Go to brave://settings/help and wait for the update and click on Relaunch
Confirmed that the 1.39.x public releases version is installed successfully

1.38.90	1.39.106

Case 4: Install standalone installer 1.38.x and then auto upgrade_PASSED

Clean profile 1.38.x standalone installer BraveBrowserStandaloneBetaSetup.exe
Go to brave://settings/help and wait for the update and click on Relaunch
Confirmed that the 1.39.x public releases version is installed successfully

1.38.69	1.39.106

mherrmann · 2022-05-16T11:50:43Z

I took the staging update server updates.brave.com back offline because @GeetaSarvadnya said she was done with it.

LaurenWags · 2022-05-16T12:28:23Z

@mherrmann we still have to test this issue with Win 11 (@MadhaviSeelam is doing) and Win 8 (@kjozwiak will do), so sounds like we might need that back.

mherrmann · 2022-05-16T12:51:51Z

@LaurenWags I see. I'm bringing staging back online.

LaurenWags · 2022-05-16T18:25:39Z

Thanks @mherrmann - we should be able to get back to this once we get some other priorities completed.

LaurenWags · 2022-05-18T15:44:03Z

Verified with:

Brave	1.39.106 Chromium: 101.0.4951.67 (Official Build) beta (32-bit) 
Revision	8888ee7a24e2c36661ddb9536c35b7d4852a3a98-refs/branch-heads/4951@{#1230}
OS	Windows 10 Version 21H2 (Build 19044.1682)

Verified the test plan from Bump the Windows updater (Omaha) to v1.3.361.113 brave-core#12895

Windows 10 x86

1. Verify installers and auto-updater work on a clean profile

Case 1: Verify the Omaha updater version when 1.39.x is installed - PASSED

Pre-requisites:
(Please note these steps are same as remove updater as described in the "Cleaning up after a test" in brave/brave-core#11096 but I have breakdown the steps into detailed)

Uninstall all the brave version (all channels Dev, Release, Beta and Nightly) via Control panel
Remove all the local profile folders from %LOCALAPPDATA%\BraveSoftware
Go to C:\Program Files (x86)\BraveSoftware\update path and observe that Update folder is still available and updater version 1.3.361.113 is still shown
Open RegEdit and navigate to Computer\HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\Update and ensure Omaha updater version is 1.3.361.113
Open command prompt with Admin privileges and run the command "C:\Program Files (x86)\BraveSoftware\Update\BraveUpdate.exe" /uninstall
Go to C:\Program Files (x86)\BraveSoftware path and observe that the update folder is removed
Open RegEdit and navigate to Computer\HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\Update and ensure Omaha updater version 1.3.361.113 is removed from the registry
If the registry key isn't empty in steps 6 and 7 then kill all instances of BraveUpdate.exe, BraveCrashHandler.exe, BraveCrashHandler64.exe in the Task Manager
Steps 6 and 7 indicate that the Omaha updater is completely uninstalled

Steps:

Run the steps 1 to 7 from Pre-requisites above - N/A as I used a fresh VM with Brave never having been installed
Download BraveBrowserStandaloneBetaSetup32.exe for 1.39.106 and install the standalone binary 1.39.x with Admin rights and ensured that standalone installer installed successfully
Confirmed that the new Omaha updater 1.3.361.113 is shown in the registry as expected
Confirmed new Omaha updater version 1.3.361.113 is shown in C:\Program Files (x86)\BraveSoftware\Update
Uninstall the 1.39.x from control panel and remove the profile folder from the %LOCALAPPDATA%\BraveSoftware
Install the 1.39.x again (installed 1.38.101 this time) and confirmed that the brave installed successfully
Go to brave://settings/help and wait for the update and and click on the Relaunch and confirmed that brave is upgraded to latest public version

Step 3	Step 4	Step 6	Step 7

2. Verify installers and auto-updater works on upgrade profile

Case 1:Verify the Omaha updater version in an upgraded profile (Install 1.37.77 ->upgrade to 1.39.x) - PASSED

Steps :

Follow the pre-requisites steps from case 1 to uninstall the Omaha - N/A as I used a fresh VM without Brave ever being installed
Install the BraveBrowserStandaloneBetaSetup32.exe build version 1.37.77 (build before the Omaha updater change 1.3.361.113)
Confirmed build is installed successfully and version details are shown correctly in brave://settings/help
Confirmed that the old Omaha updater 1.3.361.111 is shown in the registry as expected
Confirmed old Omaha updater version 1.3.361.111 is shown in C:\Program Files (x86)\BraveSoftware\Update
Go to brave://settings/help and wait for update and click on Relaunch and ensured brave is updated to the latest public beta version 1.39.x

1.37.77

Step 4	Step 5	Step 6	Step 6

Worked with Geeta to understand and follow the steps from 1.) #22060 (comment) and then 2.) "Background updates" in brave/brave-core#11096 - to verify the Omaha updates silently in the background and confirmed that updater got updated to latest version 1.3.361.113.

Confirmed Omaha updater version updated from 1.3.361.111 --> 1.3.361.113

Case 2: Download and install stub installer binary 1.39.x with Admin rights - PASSED

Uninstall 1.39.x from the control panel if it's installed - N/A as I'm using a fresh VM and Brave has never been installed
Remove local profile folders from %LOCALAPPDATA%\BraveSoftware - N/A as I'm using a fresh VM and Brave has never been installed
Install 1.39.x stub installer BraveBrowserBetaSetup32.exe and ensured that brave is installed successfully and latest public released beta version is fetched from the Omaha server as expected
- NOTE: Train migration has occurred. Thus, BraveBrowserBetaSetup32.exe stub installer is returning 1.40.x version of Beta, which is expected.
- Due to the above, on a fresh VM I also downloaded and installed BraveBrowserSetup32-86-r-test.exe (from https://bravesoftware.slack.com/archives/C0YL5KMA8/p1590607737165700) which is the stub installer for the test Release channel. This installed 1.39.x on release channel, 1.39.109, as expected.

.	1.40.x (Beta)	1.39.x (Release via `test` channel)
Brave	1.40.68 Chromium: 102.0.5005.50 (Official Build) beta (32-bit)	1.39.109 Chromium: 102.0.5005.50 (Official Build) (32-bit)
Revision	f6e2cf8f59ec714bdcff8499991d55898875f287-refs/branch-heads/5005@{#648}	f6e2cf8f59ec714bdcff8499991d55898875f287-refs/branch-heads/5005@{#648}
OS	Windows 10 Version 21H2 (Build 19044.1706)	Windows 10 Version 21H2 (Build 19044.1706)

Case 3: Download and install standalone silent installer binary 1.39.x - PASSED

Uninstall 1.39.x from the control panel if it's installed - N/A (fresh VM)
Remove local profile folders from %LOCALAPPDATA%\BraveSoftware - N/A (fresh VM)
Install 1.39.x standalone silent installer BraveBrowserStandaloneSilentSetup32.exe and ensured that brave is installed in silent mode (Installer modal is NOT shown on the UI) and ensured that correct version details are shown brave://settings/help

Brave	1.39.109 Chromium: 102.0.5005.50 (Official Build) (32-bit) 
Revision	f6e2cf8f59ec714bdcff8499991d55898875f287-refs/branch-heads/5005@{#648}
OS	Windows 10 Version 21H2 (Build 19044.1706)

3. Verify installers and auto-updater work when the user declines the Admin rights in UAC

Case 1: Verify standalone installer can be installed without admin rights and updater works - PASSED

Install 1.39.x beta standalone installer
Decline the Admin rights in UAC while installing the setup
Confirmed 1.39.x beta standalone installer is installed successfully
Go to brave://settings/help and wait for the update and click on Relaunch
Confirmed that the brave is upgraded to 1.39.x beta public released version

Installed 1.39.96 --> Updated to 1.39.106

Example	Example	Example	Example	Example

4. Verify re-install same installer version works

Case 1: Verify standalone installer can be installed twice and update works - PASSED

Install 1.39.x standalone installer twice
Ensured two brave windows are opened with the same version
Go to brave://settings/help and wait for the update and click on Relaunch
Confirmed that brave is updated to 1.39.x public released version

Example	Example

5. Install quite older installers and check update works correctly

Case 1: Install 1.30.x and ensure upgrade works - PASSED

Install 1.30.x beta build
Go to brave://settings/help and wait for update and click on Relaunch
Confirmed 1.39.x public released version is installed

1.30.x	1.39.x

6. Verify that install brave works when the Internet is disconnected

Case 1: Verify standalone installer can be installed when the network is disconnected - PASSED

Install 1.39.x standalone installer
Confirmed standalone installer is installed successfully and version details are shown correctly
Go to brave://settings/help and ensured update is NOT shown which is expected as to pull the Omaha version network needs to be connected

7. Verify installing a new binary by older binary from different installers (e.g one is standalone and the other is stub/silent)

Case 1: Install standalone installer 1.38.x and upgrade it by 1.39.x stub installer - PASSED

Clean profile 1.38.x standalone installer BraveBrowserStandaloneSetup32.exe
Install the standalone installer and confirmed 1.38.x is installed successfully
Upgrade the profile by 1.39.x stub installer BraveBrowserBetaSetup32.exe
Confirmed that the 1.39.x public releases version is installed successfully

1.38.x	1.38.x	1.39.x	1.39.x

btlechowski · 2022-05-23T21:30:39Z

Verification passed on

Brave	1.39.111 Chromium: 102.0.5005.61 (Official Build) (64-bit)
Revision	0e59bcc00cc4985ce39ad31c150065f159d95ad3-refs/branch-heads/5005@{#819}
OS	Windows 7 Service Pack 1 (Build 7601.24544)

Verified the test plan from Bump the Windows updater (Omaha) to v1.3.361.113 brave-core#12895

Windows 7 x64

1. Verify installers and auto-updater work on a clean profile

Case 2: Download and install stub installer binary 1.39.x with Admin rights_PASSED

Uninstall 1.39.x from the control panel if it's installed
Remove local profile folders from %LOCALAPPDATA%\BraveSoftware
Install 1.39.x stub installer BraveBrowserBetaSetup.exe and ensured that brave is installed successfully and latest public released beta version is fetched from the Omaha server as expected

2. Verify installers and auto-updater works on upgrade profile

Case 2: Install standalone installer 1.38.x and upgrade the profile to 1.39.x_PASSED

Install standalone beta installer 1.38.x
Go to brave://settings/help and wait for the update and click on Relaunch
Confirmed that brave is upgraded to 1.39.x public released version

3. Verify installers and auto-updater work when the user declines the Admin rights in UAC

[Note : when brave is installed for the current user (without admin rights) the Brave-Browser-Beta folder gets created under the registry path Computer\HKEY_CURRENT_USER\SOFTWARE\BraveSoftware\ and Omaha new updater version is shown as expected (detailed testing for the current user is covered in https://github.com//issues/22179#issuecomment-1112647799]

Case 2: Verify stub installer can be installed without admin rights_PASSED

Install 1.39.x beta stub installer
Decline the Admin rights in UAC while installing the setup
Confirmed 1.39.x public released beta version is installed

4. Verify re-install same installer version works

Case 1: Verify standalone installer can be installed twice and update works_PASSED

Install 1.39.x standalone installer twice
Ensured two brave windows are opened with the same version
Go to brave://settings/help and wait for the update and click on Relaunch
Confirmed that brave is updated to 1.39.x public released version

5. Install quite older installers and check update works correctly

Case 1: Install 1.30.x and ensure upgrade works_PASSED

Install 1.30.x beta build
Go to brave://settings/help and wait for update and click on Relaunch
Confirmed 1.39.x public released version is installed

6. Verify that install brave works when the Internet is disconnected

Case 1: Verify standalone installer can be installed when the network is disconnected_PASSED

Install 1.39.x standalone installer
Confirmed standalone installer is installed successfully and version details are shown correctly
Go to brave://settings/help and ensured update is NOT shown which is expected as to pull the Omaha version network needs to be connected

7. Verify installing a new binary by older binary from different installers (e.g one is standalone and the other is stub/silent)

Case 1: Install standalone installer 1.38.x and upgrade it by 1.39.x stub installer_PASSED

Clean profile 1.38.x standalone installer BraveBrowserStandaloneSetup.exe
Install the standalone installer and confirmed 1.38.x is installed successfully
Upgrade the profile by 1.39.x stub installer BraveBrowserBetaSetup.exe
Confirmed that the 1.39.x public releases version is installed successfully

- Added Solana support for account creation, sending SOL and sending SPL tokens with Brave Wallet. ([#22348](brave/brave-browser#22348)) - Added the ability to buy with Ramp using Brave Wallet. ([#21639](brave/brave-browser#21639)) - Added JSONSanitizer to API helper requests for Brave Wallet. ([#21831](brave/brave-browser#21831)) - Added Dapp UI for requesting a public key and for decrypting ciphers using Brave Wallet. ([#21177](brave/brave-browser#21177)) - Added web3_clientVersion support for Brave Wallet. ([#19278](brave/brave-browser#19278)) - Added the ability to allow users to search sites for RSS feeds for Brave News. ([#21768](brave/brave-browser#21768)) - Added support for blob partitioning. ([#21746](brave/brave-browser#21746)) - Added minimum macOS version for Sparkle update process. ([#22918](brave/brave-browser#22918)) - [Security] Blocked "window.ethereum" completely in third party iframes. ([#22686](brave/brave-browser#22686)) - [Security] Updated Brave Wallet panel to prominently display eTLD+1 as reported on HackerOne by renekroka. ([#21787](brave/brave-browser#21787)) - [Security] Fixed incorrect origin being displayed in Brave Wallet when a spend approval is pending. ([#19557](brave/brave-browser#19557)) - Implemented eth_getEncryptionPublicKey for Brave Wallet. ([#19276](brave/brave-browser#19276)) - Implemented account discovery when restoring Brave Wallet. ([#18104](brave/brave-browser#18104)) - Updated Omaha installer version for Windows to v1.3.36.113. ([#22060](brave/brave-browser#22060)) - Updated default IPFS configuration values. ([#22068](brave/brave-browser#22068)) - Updated Gas Limit validation and error messaging for unapproved transactions with Brave Wallet. ([#21714](brave/brave-browser#21714)) - Updated Brave Wallet to automatically add swap taker asset to the visible asset list. ([#21428](brave/brave-browser#21428)) - Updated Brave Wallet portfolio network filter for multichain support. ([#20780](brave/brave-browser#20780)) - Reduced adblock filter memory usage by optimizing unused regex rules. ([#21970](brave/brave-browser#21970)) - Removed known Dialog Insight user tracking parameters from URLs. ([#22082](brave/brave-browser#22082)) - Removed ability to swap ERC721 tokens with Brave Wallet. ([#21550](brave/brave-browser#21550)) - Fixed crash which occurred when opening Brave Shields while using Google Meet. ([#22814](brave/brave-browser#22814)) - Fixed inability to rename Solana account in Brave Wallet after it has been created. ([#22958](brave/brave-browser#22958)) - Fixed incorrectly computed insufficient funds errors in Brave Wallet. ([#22877](brave/brave-browser#22877)) - Fixed ERC20 and ERC721 transfers being incorrectly displayed as ETH transfers in the Brave Wallet transactions panel. ([#22044](brave/brave-browser#22044)) - Fixed text alignment issues under the Brave Wallet "Recent transactions" panel when using long account names. ([#21216](brave/brave-browser#21216)) - Fixed breakage in webpack build caused by OpenSSL 3.0. ([#22305](brave/brave-browser#22305)) - Fixed two windows being opened on launch when the browser was installed without administrator privileges on Windows. ([#22179](brave/brave-browser#22179)) - Upgraded Chromium to 102.0.5005.61. ([#22923](brave/brave-browser#22923)) ([Changelog for 102.0.5005.61](https://chromium.googlesource.com/chromium/src/+log/101.0.4951.67..102.0.5005.61?pretty=fuller&n=1000))

mherrmann added OS/Windows feature/updater QA/Yes release-notes/include installer/omaha Issues for windows omaha installer OS/Desktop labels Apr 4, 2022

mherrmann added this to the 1.39.x - Nightly milestone Apr 4, 2022

mherrmann self-assigned this Apr 4, 2022

This was referenced Apr 4, 2022

Update Brave's Windows updater (Omaha) #21564

Closed

Bump Windows updater to v 1.3.361.121 brave/brave-core#12868

Merged

mherrmann closed this as completed in brave/brave-core#12868 Apr 4, 2022

mherrmann reopened this Apr 5, 2022

mherrmann changed the title ~~Update Brave's Windows updater (Omaha)~~ Update Brave's Windows updater (Omaha) to v1.3.361.113 Apr 5, 2022

mherrmann changed the title ~~Update Brave's Windows updater (Omaha) to v1.3.361.113~~ Bump Brave's Windows updater (Omaha) to v1.3.361.113 Apr 5, 2022

mherrmann mentioned this issue Apr 5, 2022

Bump the Windows updater (Omaha) to v1.3.361.113 brave/brave-core#12895

Merged

25 tasks

mherrmann closed this as completed in brave/brave-core#12895 Apr 7, 2022

GeetaSarvadnya mentioned this issue May 10, 2022

Windows Standalone installer: Two browser windows open when installing as non-admin #22179

Closed

GeetaSarvadnya added the QA/Blocked label May 10, 2022

GeetaSarvadnya removed the QA/Blocked label May 11, 2022

LaurenWags mentioned this issue May 23, 2022

Desktop Release Notes for 1.39.x - Release #23010

Closed

kjozwiak added the QA Pass-Win64 label Jun 7, 2022

MadhaviSeelam mentioned this issue Jun 22, 2022

Update Omaha (Brave's auto-updater on Windows) to 1.3.36.131 #23047

Closed

MadhaviSeelam mentioned this issue Jan 3, 2023

Provide Windows ARM64 binary #6319

Closed

GeetaSarvadnya mentioned this issue Feb 17, 2023

Rotate the Windows update key #28091

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump Brave's Windows updater (Omaha) to v1.3.361.113 #22060

Bump Brave's Windows updater (Omaha) to v1.3.361.113 #22060

mherrmann commented Apr 4, 2022 •

edited

Loading

mherrmann commented Apr 5, 2022 •

edited

Loading

LaurenWags commented Apr 28, 2022 •

edited

Loading

GeetaSarvadnya commented May 6, 2022 •

edited

Loading

GeetaSarvadnya commented May 10, 2022

GeetaSarvadnya commented May 11, 2022 •

edited

Loading

mherrmann commented May 11, 2022

GeetaSarvadnya commented May 12, 2022 •

edited

Loading

mherrmann commented May 12, 2022

GeetaSarvadnya commented May 12, 2022 •

edited

Loading

MadhaviSeelam commented May 13, 2022 •

edited

Loading

mherrmann commented May 16, 2022

LaurenWags commented May 16, 2022

mherrmann commented May 16, 2022

LaurenWags commented May 16, 2022

LaurenWags commented May 18, 2022 •

edited

Loading

btlechowski commented May 23, 2022

Bump Brave's Windows updater (Omaha) to v1.3.361.113 #22060

Bump Brave's Windows updater (Omaha) to v1.3.361.113 #22060

Comments

mherrmann commented Apr 4, 2022 • edited Loading

Description

mherrmann commented Apr 5, 2022 • edited Loading

LaurenWags commented Apr 28, 2022 • edited Loading

GeetaSarvadnya commented May 6, 2022 • edited Loading

Windows 10 x64

GeetaSarvadnya commented May 10, 2022

GeetaSarvadnya commented May 11, 2022 • edited Loading

mherrmann commented May 11, 2022

GeetaSarvadnya commented May 12, 2022 • edited Loading

mherrmann commented May 12, 2022

GeetaSarvadnya commented May 12, 2022 • edited Loading

MadhaviSeelam commented May 13, 2022 • edited Loading

Windows 11x64

mherrmann commented May 16, 2022

LaurenWags commented May 16, 2022

mherrmann commented May 16, 2022

LaurenWags commented May 16, 2022

LaurenWags commented May 18, 2022 • edited Loading

Windows 10 x86

btlechowski commented May 23, 2022

Windows 7 x64

mherrmann commented Apr 4, 2022 •

edited

Loading

mherrmann commented Apr 5, 2022 •

edited

Loading

LaurenWags commented Apr 28, 2022 •

edited

Loading

GeetaSarvadnya commented May 6, 2022 •

edited

Loading

GeetaSarvadnya commented May 11, 2022 •

edited

Loading

GeetaSarvadnya commented May 12, 2022 •

edited

Loading

GeetaSarvadnya commented May 12, 2022 •

edited

Loading

MadhaviSeelam commented May 13, 2022 •

edited

Loading

LaurenWags commented May 18, 2022 •

edited

Loading