Windows Standalone installer: Two browser windows open when installing as non-admin

[mherrmann]

Steps to Reproduce

1. Run Brave's StandaloneSetup.exe.
2. Reject the UAC dialog asking for admin privileges.
3. Accept the follow-up dialog "do you want to install as normal user?" with yes. This installs Brave for just the current user into %LOCALAPPDATA% instead of C:\Program Files.

Actual result:

Two browser windows open, in addition to the installer dialog:

Expected result:

Just one browser window should open.

Reproduces how often:

Always.

Brave version (brave://version info)

Release 1.37.111.

Version/Channel Information:

• Can you reproduce this issue with the current release? Yes
• Can you reproduce this issue with the beta channel? Probably
• Can you reproduce this issue with the nightly channel? Yes

Miscellaneous Information:

A very similar bug #1833 affected Brave's online installer.

[mherrmann]

Just ran into #22122 while working on this.

[LaurenWags]

@brave/legacy_qa we should check Win 10 and 11 at a minimum. Win 8 and 7 would be helpful, but not strictly necessary.

[MadhaviSeelam]

Verification PASSED using

Brave	1.39.83 Chromium: 101.0.4951.41 (Official Build) beta (64-bit)
Revision	93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS	Windows 11 Version 21H2 (Build 22000.613)

• Downloaded BraveBrowserStandaloneBetaSetup.exe from https://github.com/brave/brave-browser/releases/tag/v1.39.83
• Double-clicked to install
• Click No on the User Access Control prompt
• Clicked Yes when prompted Brave-Browser-Beta can be installed without administrator privileges. Continue?
• Let installation finish
• Checked # of launched Brave windows, post-install
• Verified only one (1) browser window was launched, post-install when installing as non-admin.

ex1	ex2	ex3	ex4	ex5	ex6	ex7

Verified Regression case by selecting Yes on UAC prompt to install Brave as admin

• Downloaded BraveBrowserStandaloneBetaSetup.exe from https://github.com/brave/brave-browser/releases/tag/v1.39.83
• Double-clicked to install
• Click Yes on the User Access Control prompt
• Let installation finish
• Verified brave browser window was launched, post-install as expected.

---

Verification PASSED on

Brave | 1.39.96 Chromium: 101.0.4951.54 (Official Build) beta (64-bit)
-- | --
Revision | 67da1aeb32cedd27634ca6634fb79cbd85d3f0ab-refs/branch-heads/4951@{#1126}
OS | Windows 10 Version 21H2 (Build 19044.1645)

• Verified the test plan from Fix: Windows standalone installer opened 2 windows (WIP) brave-core#13049 and STR from the description
• Issue is reproduced in the Build version 1.37.111
  
• Installed standalone installer 1.39.x without admin rights and ensured that two browser windows are NOT opened after the installtion
  
• Confirmed that brave is just installed for the current user and the folder Application gets created under the %LOCALAPPDATA% instead of C:\Program Files
• Confirmed that Brave-Browser-Beta folder gets created under the registry path Computer\HKEY_CURRENT_USER\SOFTWARE\BraveSoftware\
  
• Confirmed that the new Omaha updater version 1.3.361.113 is shown in the updater in the registry
• Detailed testing on the installers and updater will be covered in the issue Bump Brave's Windows updater (Omaha) to v1.3.361.113 #22060