Bump Windows updater to v 1.3.361.121 #12868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This contains the following improvements: 1. Disable some statistics collection in Brave's auto-updater on Windows. 2. We pulled in the latest changes from Google's upstream implementation of the auto-updater. This gives us the latest security and stability fixes. 3. We now use Visual Studio 2019 for compiling the auto-updater. Previously, we used the less-recommended VS 2017 for building the project. 4. We now make sure there are no local changes in the updater sources inside Brave's main repository after building. This streamlines other parts of Brave's build process such as npm run sync. 5. We made a few other small improvements to the build process of the auto-updater. It now gives better error messages and requires fewer parameters for a successful build.
mherrmann
added
CI/skip-android
github-actions
bot
added
the
CI/run-audit-deps
goodov
approved these changes
Apr 4, 2022
mihaiplesa
approved these changes
Apr 4, 2022
|
This PR had to be reverted. See #12874. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR had to be reverted. See #12874.
Resolves brave/brave-browser#22060
Testers: This issue has the potential to brick Brave's auto-update fleet on Windows and needs thorough testing. Please see #11096 for a test plan.
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on