Implement module execution #2922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
added
enhancement
Test262 conformance changes
Fixed tests (154):Broken tests (8): |
|
By the way, the test count reduction is because we were running module tests twice: on no strict and strict mode. However, this is unnecessary for modules because they're strict by default, so we can just run them once. |
|
Ok, I checked the regressed tests and all of them have the |
Codecov Report
@@ Coverage Diff @@
## main #2922 +/- ##
==========================================
- Coverage 52.15% 50.45% -1.70%
==========================================
Files 436 442 +6
Lines 43777 45267 +1490
==========================================
+ Hits 22831 22840 +9
- Misses 20946 22427 +1481
|
|
All documented and added an example, this is ready for full reviews now! |
raskad
reviewed
May 13, 2023
nekevss
reviewed
May 15, 2023
HalidOdat
reviewed
May 17, 2023
HalidOdat
reviewed
May 17, 2023
HalidOdat
reviewed
May 17, 2023
raskad
reviewed
May 17, 2023
raskad
approved these changes
May 17, 2023
There was a problem hiding this comment.
Just very awesome work on this @jedel1043. I checked out #2932 locally and it seems like with these huge steps we are on a very good path for getting most of the language features done.
I also like the optimizations built into the module environment bindings and the safe design on the Status transitions.
I'm all for merging this.
HalidOdat
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2921. Will rebase ontomainwhen that PR is merged.This Pull Request closes #64. We finally have a module system! 🎉
It changes the following:
Modulestruct API from which an user can progress the loading, linking and execution of a module.Context's module APIs in favour of methods inModule.ModuleLoadertrait from where a host can define how to load and cache modules.ModuleEnvironmentthat can contain indirect references to other environment bindings.There's still more work to do though, like adding support for the
import()method, fix some parsing and linking bugs, and implementing JSON modules (Stage 3).Marking it as draft since there's a lot of documentation missing
(and apparently some bugs), but I wanted to put out the PR for reviews on the implementation.