-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate declarative environment kinds #2921
Conversation
Test262 conformance changes
|
Codecov Report
@@ Coverage Diff @@
## main #2921 +/- ##
==========================================
+ Coverage 51.98% 52.06% +0.08%
==========================================
Files 431 435 +4
Lines 43647 43689 +42
==========================================
+ Hits 22690 22748 +58
+ Misses 20957 20941 -16
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice refactor! This makes the runtime environment code much more readable. Great work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice refactor! :)
This Pull Request separates declarative environments into kinds, which makes it easier to add more kinds in the future (spoiler: module environments).