-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement dynamic imports #2932
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2932 +/- ##
==========================================
- Coverage 50.39% 50.15% -0.25%
==========================================
Files 444 446 +2
Lines 45349 45760 +411
==========================================
+ Hits 22854 22951 +97
- Misses 22495 22809 +314
|
Test262 conformance changes
Fixed tests (812):
|
d974269
to
2499ec6
Compare
58fa828
to
63f9ee2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! Great work! @jedel1043
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great work. Nice refactor on the ast aswell.
I've only got one link that should probably be changed.
Depends on #2922This Pull Request implements the
import()
function that enables dynamic imports on scripts. It also adjusts our script API sinceScript
s need to be accessed by several host hooks.Additionally, fixes some more module tests.