[Merged by Bors] - Module parsing #2411
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razican
added
enhancement
Test262 conformance changes
Fixed tests (747):New panics (12): |
Codecov Report
@@ Coverage Diff @@
## main #2411 +/- ##
==========================================
- Coverage 49.40% 48.56% -0.85%
==========================================
Files 380 386 +6
Lines 37884 38572 +688
==========================================
+ Hits 18718 18731 +13
- Misses 19166 19841 +675
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Razican
force-pushed
the
import_parse
branch
2 times, most recently
from
9bd4c8d to
d6d956a
Compare
Razican
force-pushed
the
import_parse
branch
2 times, most recently
from
fe39f08 to
27c899f
Compare
jedel1043
force-pushed
the
import_parse
branch
from
5e7cfe5 to
dc54c88
Compare
|
Rebased. I'll start contributing to this on the next days |
bors bot
pushed a commit
that referenced
this pull request
Jan 19, 2023
Follows from #2528, and should complement #2411 to implement the module import hooks. ~~Similarly to the Intl/ICU4X PR (#2478), this has a lot of trivial changes caused by the new lifetimes. I thought about passing the queue and the hooks by value, but it was very painful having to wrap everything with `Rc` in order to be accessible by the host. In contrast, `&dyn` can be easily provided by the host and has the advantage of not requiring additional allocations, with the downside of adding two more lifetimes to our `Context`, but I think it's worth.~~ I was able to unify all lifetimes into the shortest one of the three, making our API just like before! Changes: - Added a new `HostHooks` trait and a `&dyn HostHooks` field to `Context`. This allows hosts to implement the trait for their custom type, then pass it to the context. - Added a new `JobQueue` trait and a `&dyn JobQueue` field to our `Context`, allowing custom event loops and other fun things. - Added two simple implementations of `JobQueue`: `IdleJobQueue` which does nothing and `SimpleJobQueue` which runs all jobs until all successfully complete or until any of them throws an error. - Modified `boa_cli` to run all jobs until the queue is empty, even if a job returns `Err`. This also prints all errors to the user.
bors bot
pushed a commit
that referenced
this pull request
Jan 29, 2023
Extracted from #2411 to reduce its size a bit. This PR: - Renames `Identifier` to `IdentifierName`, which is the name stated in the spec. - Renames the utility function `check_parser` to `check_script_parser` to prepare for modules. - Adds some missing `#[inline]` and rewrites some patterns.
bors bot
pushed a commit
that referenced
this pull request
Jan 29, 2023
Extracted from #2411 to reduce its size a bit. This PR: - Renames `Identifier` to `IdentifierName`, which is the name stated in the spec. - Renames the utility function `check_parser` to `check_script_parser` to prepare for modules. - Adds some missing `#[inline]` and rewrites some patterns.
jedel1043
force-pushed
the
import_parse
branch
from
dc54c88 to
df178f2
Compare
bors bot
pushed a commit
that referenced
this pull request
Jan 31, 2023
Slightly related to #2411 since we need an API to pass module files, but more useful for #1760, #1313 and other error reporting issues. It changes the following: - Introduces a new `Source` API to store the path of a provided file or `None` if the source is a plain string. - Improves the display of `boa_tester` to show the path of the tests being run. This also enables hyperlinks to directly jump to the tested file from the VS terminal. - Adjusts the repo to this change. Hopefully, this will improve our error display in the future.
bors bot
pushed a commit
that referenced
this pull request
Feb 1, 2023
Another change extracted from #2411. This PR changes the following: - Improves our identifier parsing with a new `Identifier` parser that unifies parsing for `IdentifierReference`, `BindingIdentifier` and `LabelIdentifier`. - Slightly improves some error messages. - Extracts our manual initialization of static `Sym`s with a new `static_syms` proc macro. - Adds `set_module_mode` and `module_mode` to the cursor to prepare for modules.
bors bot
pushed a commit
that referenced
this pull request
Feb 1, 2023
Another change extracted from #2411. This PR changes the following: - Improves our identifier parsing with a new `Identifier` parser that unifies parsing for `IdentifierReference`, `BindingIdentifier` and `LabelIdentifier`. - Slightly improves some error messages. - Extracts our manual initialization of static `Sym`s with a new `static_syms` proc macro. - Adds `set_module_mode` and `module_mode` to the cursor to prepare for modules.
jedel1043
force-pushed
the
import_parse
branch
from
b4fb15d to
f0979cf
Compare
jedel1043
force-pushed
the
import_parse
branch
from
661b39f to
d4588ef
Compare
|
Parsing is done! There are still some missing details like checking Some tests will obviously panic because this doesn't implement the runtime part of modules, but it would be better to do that on a follow-up PR since this one is getting big enough already. Also, I removed the link to the modules issue to avoid Bors closing it. |
jedel1043
requested review from
raskad,
HalidOdat,
jasonwilliams,
nekevss and
RageKnify
raskad
approved these changes
Feb 3, 2023
nekevss
approved these changes
Feb 4, 2023
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 4, 2023
I'm creating this draft PR, since I wanted to have some early feedback, and because I though I would have time to finish it last week, but I got caught up with other stuff. Feel free to contribute :) The main thing here is that I have divided `eval()`, `parse()` and similar functions so that they can decide if they are parsing scripts or modules. Let me know your thoughts. Then, I was checking the import & export parsing, and I noticed we are using `TokenKind::Identifier` for `IdentifierName`, so I changed that name. An `Identifier` is an `IdentifierName` that isn't a `ReservedWord`. This means we should probably also adapt all `IdentifierReference`, `BindingIdentifier` and so on parsing. I already created an `Identifier` parser. Something interesting there is that `await` is not a valid `Identifier` if the goal symbol is `Module`, as you can see in the [spec](https://tc39.es/ecma262/#prod-LabelIdentifier), but currently we don't have that information in the `InputElement` enumeration, we only have `Div`, `RegExp` and `TemplateTail`. How could we approach this? Co-authored-by: jedel1043 <[email protected]>
|
Pull request successfully merged into main. Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm creating this draft PR, since I wanted to have some early feedback, and because I though I would have time to finish it last week, but I got caught up with other stuff. Feel free to contribute :)
The main thing here is that I have divided
eval(),parse()and similar functions so that they can decide if they are parsing scripts or modules. Let me know your thoughts.Then, I was checking the import & export parsing, and I noticed we are using
TokenKind::IdentifierforIdentifierName, so I changed that name. AnIdentifieris anIdentifierNamethat isn't aReservedWord. This means we should probably also adapt allIdentifierReference,BindingIdentifierand so on parsing. I already created anIdentifierparser.Something interesting there is that
awaitis not a validIdentifierif the goal symbol isModule, as you can see in the spec, but currently we don't have that information in theInputElementenumeration, we only haveDiv,RegExpandTemplateTail. How could we approach this?