-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Rename check_parser
and Identifier
#2576
Conversation
Test262 conformance changes
|
Codecov Report
@@ Coverage Diff @@
## main #2576 +/- ##
==========================================
+ Coverage 49.99% 50.01% +0.01%
==========================================
Files 380 379 -1
Lines 37846 37827 -19
==========================================
- Hits 18921 18919 -2
+ Misses 18925 18908 -17
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
bors r+ |
Extracted from #2411 to reduce its size a bit. This PR: - Renames `Identifier` to `IdentifierName`, which is the name stated in the spec. - Renames the utility function `check_parser` to `check_script_parser` to prepare for modules. - Adds some missing `#[inline]` and rewrites some patterns.
Build failed: |
bors retry |
Extracted from #2411 to reduce its size a bit. This PR: - Renames `Identifier` to `IdentifierName`, which is the name stated in the spec. - Renames the utility function `check_parser` to `check_script_parser` to prepare for modules. - Adds some missing `#[inline]` and rewrites some patterns.
Pull request successfully merged into main. Build succeeded: |
check_parser
and Identifier
check_parser
and Identifier
Extracted from #2411 to reduce its size a bit.
This PR:
Identifier
toIdentifierName
, which is the name stated in the spec.check_parser
tocheck_script_parser
to prepare for modules.#[inline]
and rewrites some patterns.