Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Rename check_parser and Identifier #2576

Closed
wants to merge 1 commit into from

Conversation

jedel1043
Copy link
Member

Extracted from #2411 to reduce its size a bit.

This PR:

  • Renames Identifier to IdentifierName, which is the name stated in the spec.
  • Renames the utility function check_parser to check_script_parser to prepare for modules.
  • Adds some missing #[inline] and rewrites some patterns.

@jedel1043 jedel1043 added parser Issues surrounding the parser API labels Jan 29, 2023
@jedel1043 jedel1043 added this to the v0.17.0 milestone Jan 29, 2023
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 94,205 94,205 0
Passed 70,720 70,720 0
Ignored 18,622 18,622 0
Failed 4,863 4,863 0
Panics 0 0 0
Conformance 75.07% 75.07% 0.00%

@codecov
Copy link

codecov bot commented Jan 29, 2023

Codecov Report

Merging #2576 (9071a5e) into main (bd0652f) will increase coverage by 0.01%.
The diff coverage is 42.30%.

@@            Coverage Diff             @@
##             main    #2576      +/-   ##
==========================================
+ Coverage   49.99%   50.01%   +0.01%     
==========================================
  Files         380      379       -1     
  Lines       37846    37827      -19     
==========================================
- Hits        18921    18919       -2     
+ Misses      18925    18908      -17     
Impacted Files Coverage Δ
boa_parser/src/lexer/error.rs 58.33% <0.00%> (ø)
boa_parser/src/parser/expression/assignment/mod.rs 78.74% <0.00%> (-0.63%) ⬇️
...a_parser/src/parser/expression/assignment/yield.rs 35.18% <0.00%> (ø)
...xpression/primary/async_function_expression/mod.rs 59.67% <0.00%> (ø)
...pression/primary/async_generator_expression/mod.rs 59.21% <0.00%> (ø)
.../parser/expression/primary/class_expression/mod.rs 0.00% <0.00%> (ø)
...rser/expression/primary/function_expression/mod.rs 61.81% <0.00%> (ø)
...ser/expression/primary/generator_expression/mod.rs 54.83% <0.00%> (ø)
boa_parser/src/parser/expression/primary/mod.rs 55.58% <0.00%> (ø)
boa_parser/src/parser/statement/try_stm/catch.rs 88.70% <0.00%> (ø)
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@raskad
Copy link
Member

raskad commented Jan 29, 2023

bors r+

bors bot pushed a commit that referenced this pull request Jan 29, 2023
Extracted from #2411 to reduce its size a bit.

This PR:
- Renames `Identifier` to `IdentifierName`, which is the name stated in the spec.
- Renames the utility function `check_parser` to `check_script_parser` to prepare for modules.
- Adds some missing `#[inline]` and rewrites some patterns.
@bors
Copy link

bors bot commented Jan 29, 2023

Build failed:

@jedel1043
Copy link
Member Author

bors retry

bors bot pushed a commit that referenced this pull request Jan 29, 2023
Extracted from #2411 to reduce its size a bit.

This PR:
- Renames `Identifier` to `IdentifierName`, which is the name stated in the spec.
- Renames the utility function `check_parser` to `check_script_parser` to prepare for modules.
- Adds some missing `#[inline]` and rewrites some patterns.
@bors
Copy link

bors bot commented Jan 29, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Rename check_parser and Identifier [Merged by Bors] - Rename check_parser and Identifier Jan 29, 2023
@bors bors bot closed this Jan 29, 2023
@bors bors bot deleted the modules-pr-parser branch January 29, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API parser Issues surrounding the parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants