-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Improve identifier parsing #2581
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
added
parser
Issues surrounding the parser
Internal
Category for changelog
labels
Jan 31, 2023
jedel1043
requested review from
Razican,
jasonwilliams,
HalidOdat,
RageKnify,
raskad and
nekevss
January 31, 2023 23:09
Test262 conformance changes
|
Codecov Report
@@ Coverage Diff @@
## main #2581 +/- ##
==========================================
- Coverage 49.93% 49.84% -0.10%
==========================================
Files 381 381
Lines 37899 37974 +75
==========================================
+ Hits 18925 18927 +2
- Misses 18974 19047 +73
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
raskad
approved these changes
Feb 1, 2023
nekevss
approved these changes
Feb 1, 2023
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 1, 2023
Another change extracted from #2411. This PR changes the following: - Improves our identifier parsing with a new `Identifier` parser that unifies parsing for `IdentifierReference`, `BindingIdentifier` and `LabelIdentifier`. - Slightly improves some error messages. - Extracts our manual initialization of static `Sym`s with a new `static_syms` proc macro. - Adds `set_module_mode` and `module_mode` to the cursor to prepare for modules.
Build failed: |
bors retry |
bors bot
pushed a commit
that referenced
this pull request
Feb 1, 2023
Another change extracted from #2411. This PR changes the following: - Improves our identifier parsing with a new `Identifier` parser that unifies parsing for `IdentifierReference`, `BindingIdentifier` and `LabelIdentifier`. - Slightly improves some error messages. - Extracts our manual initialization of static `Sym`s with a new `static_syms` proc macro. - Adds `set_module_mode` and `module_mode` to the cursor to prepare for modules.
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Improve identifier parsing
[Merged by Bors] - Improve identifier parsing
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another change extracted from #2411.
This PR changes the following:
Identifier
parser that unifies parsing forIdentifierReference
,BindingIdentifier
andLabelIdentifier
.Sym
s with a newstatic_syms
proc macro.set_module_mode
andmodule_mode
to the cursor to prepare for modules.