Loosen tenacity dependency #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -134,7 +134,9 @@ def initialize_options(self) -> None: | |||
| ) | |||
|
|
|||
| airflow_dependencies = [ | |||
| 'apache-airflow>=1.10,<2' | |||
| # Minimum version here is needed to avoid syntax error in setup.py | |||
There was a problem hiding this comment.
This file, one of the 3 largest in the project, increased in size to 379 lines. The total size of those files is now 3421 lines (target: 1147). Is this file complex enough to refactor?
| @@ -134,7 +134,9 @@ def initialize_options(self) -> None: | |||
| ) | |||
|
|
|||
| airflow_dependencies = [ | |||
| 'apache-airflow>=1.10,<2' | |||
| # Minimum version here is needed to avoid syntax error in setup.py | |||
There was a problem hiding this comment.
This file, one of the 3 largest in the project, increased in size to 379 lines. The total size of those files is now 3421 lines (target: 1149). Is this file complex enough to refactor?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loosen the version of tenacity required to improve compatibility with other deps (such as airflow) especially under new pip resolver. I did a comparison of the tenacity code between 4.12 and 6.0, and didn't see anything that we relied on.