Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen tenacity dependency #158

Merged
merged 2 commits into from
Jan 22, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .python-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
records-mover-3.9.0
records-mover-3.9.1
2 changes: 1 addition & 1 deletion deps.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export SLUGIFY_USES_TEXT_UNIDECODE=yes
brew update && ( brew upgrade pyenv || true )
pyenv rehash # needed if pyenv is updated

python_version=3.9.0
python_version=3.9.1
# zipimport.ZipImportError: can't decompress data; zlib not available:
# You may need `xcode-select --install` on OS X
# https://github.com/pyenv/pyenv/issues/451#issuecomment-151336786
Expand Down
2 changes: 1 addition & 1 deletion metrics/bigfiles_high_water_mark
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1147
1149
6 changes: 4 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,9 @@ def initialize_options(self) -> None:
)

airflow_dependencies = [
'apache-airflow>=1.10,<2'
# Minimum version here is needed to avoid syntax error in setup.py

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file, one of the 3 largest in the project, increased in size to 379 lines. The total size of those files is now 3421 lines (target: 1147). Is this file complex enough to refactor?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file, one of the 3 largest in the project, increased in size to 379 lines. The total size of those files is now 3421 lines (target: 1149). Is this file complex enough to refactor?

# in 1.10.0
'apache-airflow>=1.10.1,<2'
]

db_dependencies = [
Expand Down Expand Up @@ -326,7 +328,7 @@ def initialize_options(self) -> None:
# resulting in runtime complaints. Can be removed once 20.4
# is proven to work.
'chardet>=3,<4',
'tenacity>=6<7',
'tenacity>=4.12.0,<7',
# v5.0.1 resolves https://github.com/exhuma/config_resolver/issues/69
'config-resolver>=5.0.1,<6',
'typing_inspect',
Expand Down