Skip to content

Commit

Permalink
Loosen tenacity dependency (#158)
Browse files Browse the repository at this point in the history
Loosen the version of tenacity required to improve compatibility with other deps (such as airflow) especially under new pip resolver. I did a comparison of the tenacity code between 4.12 and 6.0, and didn't see anything that we relied on.
  • Loading branch information
cwegrzyn authored Jan 22, 2021
1 parent 1c3f0f2 commit 4757c2d
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .python-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
records-mover-3.9.0
records-mover-3.9.1
2 changes: 1 addition & 1 deletion deps.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export SLUGIFY_USES_TEXT_UNIDECODE=yes
brew update && ( brew upgrade pyenv || true )
pyenv rehash # needed if pyenv is updated

python_version=3.9.0
python_version=3.9.1
# zipimport.ZipImportError: can't decompress data; zlib not available:
# You may need `xcode-select --install` on OS X
# https://github.com/pyenv/pyenv/issues/451#issuecomment-151336786
Expand Down
2 changes: 1 addition & 1 deletion metrics/bigfiles_high_water_mark
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1147
1149
6 changes: 4 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,9 @@ def initialize_options(self) -> None:
)

airflow_dependencies = [
'apache-airflow>=1.10,<2'
# Minimum version here is needed to avoid syntax error in setup.py
# in 1.10.0
'apache-airflow>=1.10.1,<2'
]

db_dependencies = [
Expand Down Expand Up @@ -326,7 +328,7 @@ def initialize_options(self) -> None:
# resulting in runtime complaints. Can be removed once 20.4
# is proven to work.
'chardet>=3,<4',
'tenacity>=6<7',
'tenacity>=4.12.0,<7',
# v5.0.1 resolves https://github.com/exhuma/config_resolver/issues/69
'config-resolver>=5.0.1,<6',
'typing_inspect',
Expand Down

0 comments on commit 4757c2d

Please sign in to comment.