Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: null checks in minMax process #4632

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Conversation

ColinBuyck
Copy link
Collaborator

@ColinBuyck ColinBuyck commented Feb 5, 2025

This PR addresses #4631

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

The units summarization process was failing to handle multiple units without rent information. The first unit was correctly handled with "t.n/a" in the getDefaultSummary function but then from there the inputs to a minMax function were t.n/a and null leading to the NaN. This fix avoids the minMax comparison if the unit's associated field is null.

How Can This Be Tested/Reviewed?

Add multiple units of the same unit type to a listing that have no rent or rent as a percentage of income information. Ensure that the unit summary displays with n/a rather than NaN per month.

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

Copy link

netlify bot commented Feb 5, 2025

Deploy Preview for bloom-public-seeds ready!

Name Link
🔨 Latest commit 372d6c7
🔍 Latest deploy log https://app.netlify.com/sites/bloom-public-seeds/deploys/67a391de5256cc0008e70064
😎 Deploy Preview https://deploy-preview-4632--bloom-public-seeds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 5, 2025

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit 372d6c7
🔍 Latest deploy log https://app.netlify.com/sites/partners-bloom-dev/deploys/67a391def0c98f000884fde1
😎 Deploy Preview https://deploy-preview-4632--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 5, 2025

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit 372d6c7
🔍 Latest deploy log https://app.netlify.com/sites/bloom-exygy-dev/deploys/67a391dee3848000084a6797
😎 Deploy Preview https://deploy-preview-4632--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ColinBuyck ColinBuyck added the 1 review needed Requires 1 more review before ready to merge label Feb 5, 2025
Copy link
Collaborator

@emilyjablonski emilyjablonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦩

@emilyjablonski emilyjablonski added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed Requires 1 more review before ready to merge labels Feb 6, 2025
@ColinBuyck ColinBuyck merged commit b7441d5 into main Feb 6, 2025
24 checks passed
@ColinBuyck ColinBuyck deleted the 4631/missing-rent-summary branch February 6, 2025 18:30
ColinBuyck added a commit to metrotranscom/doorway that referenced this pull request Feb 6, 2025
ColinBuyck added a commit to housingbayarea/bloom that referenced this pull request Feb 6, 2025
ColinBuyck added a commit to metrotranscom/doorway that referenced this pull request Feb 11, 2025
ColinBuyck added a commit to housingbayarea/bloom that referenced this pull request Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants