fix: null checks in minMax process (bloom-housing#4632) (#837)

housingbayarea · Feb 17, 2025 · 9de7f32 · 9de7f32
1 parent 07eb52d
commit 9de7f32
Showing 1 changed file with 26 additions and 15 deletions.
diff --git a/api/src/utilities/unit-utilities.ts b/api/src/utilities/unit-utilities.ts
@@ -373,32 +373,43 @@ export const getUnitsSummary = (unit: Unit, existingSummary?: UnitSummary) => {
   const summary = existingSummary;
 
   // Income Range
-  summary.minIncomeRange = minMaxCurrency(
-    summary.minIncomeRange,
-    getRoundedNumber(unit.monthlyIncomeMin),
-  );
+  if (unit.monthlyIncomeMin) {
+    summary.minIncomeRange = minMaxCurrency(
+      summary.minIncomeRange,
+      getRoundedNumber(unit.monthlyIncomeMin),
+    );
+  }
 
   // Occupancy Range
-  summary.occupancyRange = minMax(summary.occupancyRange, unit.minOccupancy);
-  summary.occupancyRange = minMax(summary.occupancyRange, unit.maxOccupancy);
+  if (unit.minOccupancy) {
+    summary.occupancyRange = minMax(summary.occupancyRange, unit.minOccupancy);
+  }
+  if (unit.maxOccupancy) {
+    summary.occupancyRange = minMax(summary.occupancyRange, unit.maxOccupancy);
+  }
 
   // Rent Ranges
-  summary.rentAsPercentIncomeRange = minMax(
-    summary.rentAsPercentIncomeRange,
-    parseFloat(unit.monthlyRentAsPercentOfIncome),
-  );
-  summary.rentRange = minMaxCurrency(
-    summary.rentRange,
-    getRoundedNumber(unit.monthlyRent),
-  );
+  if (unit.monthlyRentAsPercentOfIncome) {
+    summary.rentAsPercentIncomeRange = minMax(
+      summary.rentAsPercentIncomeRange,
+      parseFloat(unit.monthlyRentAsPercentOfIncome),
+    );
+  }
+  if (unit.monthlyRent)
+    summary.rentRange = minMaxCurrency(
+      summary.rentRange,
+      getRoundedNumber(unit.monthlyRent),
+    );
 
   // Floor Range
   if (unit.floor) {
     summary.floorRange = minMax(summary.floorRange, unit.floor);
   }
 
   // Area Range
-  summary.areaRange = minMax(summary.areaRange, parseFloat(unit.sqFeet));
+  if (unit.sqFeet) {
+    summary.areaRange = minMax(summary.areaRange, parseFloat(unit.sqFeet));
+  }
 
   return summary;
 };