-
-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[legacy-framework] Use cookie prefix from config.blitz.js
instead of package.json name field
#2311
Conversation
Next step is to PR the docs for that change. Also, I think we need to have some test coverage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I fixed a bug where it wasn't working — example app test was failing.
A proper integration test can be added to test/integration/auth/
by setting the session cookie prefix and then adding a middleware to blitz.config.ts that checks and validates the res
cookies. Probably should only do it on the first request? Or a certain request like login or something.
Sweet, thanks Mina! I looked and the existing tests sufficiently cover this. I also just pushed a commit to docs canary to add this. |
Added @mabadir contributions for code |
config.blitz.js
instead of package.json name fieldconfig.blitz.js
instead of package.json name field
Replaces: #1976
Closes: blitz-js/legacy-framework#329, blitz-js/legacy-framework#335
Adds new
cookiePrefix
property tosessionMiddleware config
.What are the changes and their implications?
Feature Checklist