-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weird error if no name field in package.json #335
Comments
Hey thanks! Here's the line that needs fixed: https://github.com/blitz-js/blitz/blob/canary/packages/core/src/blitz-data.tsx#L14 If package.json name isn't available, we should default to "blitz" as the name |
Thank you for the fix! |
I don't know if it is a good idea to base the name of the cookies on the name of the project. It is an unexpected behavior from my side. I would have never expected that changing the name of the project would log out all my users... |
@lcswillems excellent point. I opened an issue for that: https://github.com/blitz-js/blitz/issues/1972 |
Steps to Reproduce
Create a new Blitzjs app:
npx blitz new blitz-app
Remove the
name
field from thepackage.json
file.Run
yarn build
.This gives this error:
The text was updated successfully, but these errors were encountered: