[legacy-framework] Use cookie prefix from config.blitz.js instead of package.json name field

[piotrski]

Closes: blitz-js/legacy-framework#329, blitz-js/legacy-framework#335

What are the changes and their implications?

Adds new cookiePrefix property to sessionMiddleware config.

module.exports = {
  middleware: [
    sessionMiddleware({
+     cookiePrefix: 'cookie',
      isAuthorized: simpleRolesIsAuthorized,
    }),
  ],
}

Instead of using the name from your package.json as a session cookie prefix, it uses the cookiePrefix from blitz.config.js

Should we add information on this somewhere in the docs?

Checklist

• Changes covered by tests (tests added if needed)
• PR submitted to blitzjs.com for any user facing changes

[flybayer]

Awesome, great job!

Main change is use name instead of type because we might need type for something else later that actually indicates type.

Then please open a PR to the docs repo to update the docs for this change

[flybayer]

Hey @piotrski, are you able to finish this up?

[piotrski]

Sure. Sorry I had a lot of stuff on my mid and was sure it was already done.

[flybayer]

@piotrski ok no problem :) I should have said something earlier

[flybayer]

@mabadir can you resolve the merge conflicts too?

[mabadir]

Yes, next on my list.

[mabadir]

The file packages/core/src/supertokens.ts was recently removed from canary. I see @piotrski; made a change to this file to include the cookiePrefix to the configuration.
I assume it is safe to remove this file from the PR, as it’s not used in the core package any longer.

@flybayer any thoughts?

[flybayer]

@mabadir
packages/core/src/supertokens.ts is now https://github.com/blitz-js/blitz/blob/canary/packages/core/src/auth/auth-types.ts

and packages/server/src/supertokens.ts is now https://github.com/blitz-js/blitz/blob/canary/packages/core/src/server/auth/sessions.ts

[flybayer]

@mabadir and then we also need a PR to the docs repo to update docs for this change