Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PM-1691] Upgrade electron builder #5038

Merged
merged 7 commits into from
Apr 10, 2023
Merged

[PM-1691] Upgrade electron builder #5038

merged 7 commits into from
Apr 10, 2023

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Mar 21, 2023

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Curious to know what breaks.

Code changes

  • file.ext: Description of what was changed and why

Screenshots

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Mar 21, 2023
@Hinton Hinton force-pushed the ps/electron-builder branch from feed7a7 to 85a0678 Compare March 31, 2023 14:35
@Hinton Hinton requested a review from joseph-flinn March 31, 2023 15:39
@Hinton Hinton changed the title Upgrade electron builder [PM-1691] Upgrade electron builder Mar 31, 2023
@Hinton Hinton marked this pull request as ready for review March 31, 2023 16:23
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@djsmith85 djsmith85 mentioned this pull request Apr 4, 2023
Open
@Hinton Hinton removed the needs-qa Marks a PR as requiring QA approval label Apr 10, 2023
@Hinton Hinton merged commit 3a4a79d into master Apr 10, 2023
@Hinton Hinton deleted the ps/electron-builder branch April 10, 2023 18:19
@Hinton Hinton mentioned this pull request May 5, 2023
Merged
@pachulo pachulo mentioned this pull request Aug 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joseph-flinn joseph-flinn joseph-flinn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hinton @joseph-flinn