Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PM-2183] Remove duplicated electron packages #5381

Merged
merged 1 commit into from
May 8, 2023
Merged

[PM-2183] Remove duplicated electron packages #5381

merged 1 commit into from
May 8, 2023

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented May 5, 2023 •
edited
Loading

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Some packages were accidentally duplicated while upgrading Electron Builder in #5038. This PR removes the duplicates.

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label May 5, 2023
@Hinton Hinton marked this pull request as ready for review May 8, 2023 13:28
@Hinton Hinton requested review from withinfocus and MGibson1 May 8, 2023 13:28
@Hinton Hinton changed the title Remove duplicated electron packages [PM-2183] Remove duplicated electron packages May 8, 2023
@Hinton Hinton removed the needs-qa Marks a PR as requiring QA approval label May 8, 2023
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label May 8, 2023
@Hinton Hinton removed the needs-qa Marks a PR as requiring QA approval label May 8, 2023
@Hinton Hinton merged commit 7aa709a into master May 8, 2023
@Hinton Hinton deleted the ps/fix-electron-packages branch May 8, 2023 14:34
jprusik pushed a commit that referenced this pull request May 10, 2023
@Hinton @jprusik
[PM-2183] Remove duplicated electron packages (#5381)
e376ec1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@withinfocus withinfocus withinfocus approved these changes

@MGibson1 MGibson1 Awaiting requested review from MGibson1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hinton @withinfocus