-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-3666] snap: set compression to lzo #6132
base: main
Are you sure you want to change the base?
Conversation
Thank you for your contribution! We've added this to our internal Community PR board for review. |
Bump; come on let's get this merged. The snap is very slow still. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pachulo Thank you for your contribution and apologies on the long wait for a review.
With #7448 we also bumped the snap-core version from core18
to core22
, which we expect to bring some more improvements for the Bitwarden snap.
Approving the changes. Going to create a separate branch to kick-off all the build workflows, which will gives us feedback on new file-sizes. Then passing it on to QA for testing.
The build is currently failing https://github.com/bitwarden/clients/actions/runs/7490825186/job/20390598188?pr=7517 Didn't quite get why AppImage is complaining, because we are changing the compression for snap. We'll need to look into it. Seems this issue has been reported at electron-userland/electron-builder#7013 |
No New Or Fixed Issues Found |
Type of change
Objective
With #5038 being now merged, you should build the snap with the compression algorithm that gives the best results for desktop apps; according to Canonical, the use of the LZO compression offers 40-74% cold startup improvements over the XZ compression:
Code changes
I've just added the
compression
option in the topsnap
key, and configured the value tolzo
Should fix #2609