Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularizing code #227

Closed
5 tasks done
ataffanel opened this issue Feb 23, 2016 · 5 comments
Closed
5 tasks done

Modularizing code #227

ataffanel opened this issue Feb 23, 2016 · 5 comments
Milestone

Comments

@ataffanel
Copy link
Member

Creating Python modules for cflib and cfclient would make it possible to push the client to pypi. So fare we will make only 2 modules: cflib and cfclient. cflib will contains the crazyflie driver and cfclient all the existing clients and the bootloader console client.

  • Separate cflib in another python module (https://github.com/bitcraze/crazyflie-lib-python)
  • Cleanup resources loading, it should be possible to run the client with python3 -m cfclient
  • Cleanup the startup scripts.
  • Document the change and how to develop
  • Push a pre-version to pypi
This was referenced Feb 23, 2016
Closed
@kentwills
Copy link
Contributor

@ataffanel, played around with this a bit with https://github.com/kentwills/vanilla-bitcraze-crazyflie-lib and https://github.com/kentwills/vanilla-bitcraze-crazyflie-sdk for a proof of concept, would be willing to put some time into this.

ataffanel added a commit to bitcraze/crazyflie-lib-python that referenced this issue Feb 24, 2016
@ataffanel
Copy link
Member Author

I just pushed a new repos: https://github.com/bitcraze/crazyflie-lib-python, it looks similar to your proof of concept, though I added the examples in the same repos.

ataffanel added a commit that referenced this issue Feb 24, 2016
Related to issue #227: reorganized the code to make the project
structure more standard.
@ataffanel
Copy link
Member Author

I pushed the modified client, I removed cflib and all the strange things we where doing with sys.path (we where using sys.path to store the location of the module and the configuration folder). Though it still access the resources and load plugin/tabs using direct file access in the module path, this should be fixed.

This was referenced Feb 25, 2016
@kentwills
Copy link
Contributor

almost there :)

@ataffanel
Copy link
Member Author

This is now considered done, the lib is pushed to pypi: https://pypi.python.org/pypi/cflib. The client can be pushed when we release the next version.

@ataffanel ataffanel modified the milestone: 2016.4.1 Apr 13, 2016
mikezter added a commit to mikezter/crazyflie-clients-python that referenced this issue Jan 27, 2017
* develop:
  bitcraze#280 Refactoring of input device config file handling.
  Changed name of LoPo graph (bitcraze#276)
  Enable the Loco Positioning tab. Closes bitcraze#276
  bitcraze#276 Improved scaling/scrolling of graphs in Lo Po tab. Supporting variable nr of anchors by only subscribing to available ranges.
  Changed layout of local positioning tab (bitcraze#276)
  bitcraze#276 Change size of anchors when highlighted
  bitcraze#276 Added dynamic color of anchors to show that the copter is in the vicinity of an anchor
  bitcraze#276 Added basic graphing of anchors and position for the Loco Positioning tab
  Added “Clear” and “Task dump” buttons to the console tab. Closes bitcraze#278
  bitcraze#276 Fixed flake8 problem
  bitcraze#276 Logging of estimated position in LoPo tab
  bitcraze#227 Removed examples that have been moved to the lib
  bitcraze#269 Collecting anchor positions and ranges in the LoPo tab
  bitcraze#276 Spike for the Loco Positioning tab
  bitcraze#269 Updated readme with information for OS X on pyqt 4 VS 5
  Update readme.md with windows pycharm setup
  Closes bitcraze#275: Save and restore main window size
  use all joystick hat motions and extract method
  Add Arnaud's suggestions
  Add QScrollArea to support resizing the main window
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants