-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For Cycle 7 (Deferred) #409
Comments
Is this work already delivered? Merged in master? I think both were in an open PR I reviewed yesterday.
This work is delivered and merged into master. |
I was under the impression that merging was a foregone conclusion. Apologies if this was a wrong conclusion. |
This only applies to code in the dao package in core not in Desktop. |
@niyid I don't see the merged PRs, only the issues. Feel free to make your compensation request again next months with listing merged PRs only. I support your contribution but that request seems to not follow our rules. |
Thanks for the support.
There had been many confusing comments concerning code reviews and
acknowledgement over the past few days mostly stemming from the reviewers
who had earlier been busy with v1.2 launch switching to pending PR reviews
while I was also busy trying to keep abreast of impact of the switch on XMR
Integration Incubator. One of such is the comment on DAO code and needing
acknowledgement from Manfred (which I thought was not necessary).
I am fine with waiting till actual PR merge and filing next cycle.
Regards.
…On Thu, 14 Nov 2019, 01:11 chimp1984, ***@***.***> wrote:
@niyid <https://github.com/niyid> I don't see the merged PRs only the
issues. Feel free to make your compensation request again next months with
listing merged PRs only. I support your contribution but that request seems
to not follow our rules.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#409?email_source=notifications&email_token=AE2MWRZDRA2Q7BPPYKCNE43QTSJSZA5CNFSM4JL3N2N2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEADZJY#issuecomment-553663655>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE2MWR2BSP33DQAHVUOLPIDQTSJSZANCNFSM4JL3N2NQ>
.
|
Thanks for your understanding! |
## Summary- BSQ requested:
- Show BSQ trade fee in % per day bisq#3292 / [Feature] Provide a way to show burned BSQ in a specific timeframe bisq#3303 / Show reputation balance in BSQ wallet stats bisq#3352
- Launch in Limbo with BisqException when last navigation no longer exists bisq#3510
- Bisq Monero Wallet proposals#110
- Migrated The XMR Integration Incubator to Protocol v1.2. This had an impact on the trading views as expected and of course the expected timelines.
- Created a diverged replica of the previously existing trade views for XMR. These will later converge in areas where there are commonalities.
- [UI] Increase "Proposals of current cycle" table size to fit the window bisq#3229
- Table view columns should use a numeric-sort algorithm bisq#3231
- Arbitration Request - Message Popup bisq#3328
- Add and rename Portfolio History columns meaningfully bisq#3338
- Vote Reveal - Silent Fail bisq#3408
2000 BSQ
Contributions delivered
1000 BSQ
1000 BSQ
(This was reviewed up both because there was an initial error in including a contribution that has been removed and the opinion that it was initially under estimated in the first place. This issue was a showstopper and was also discovered, the expected outcome defined and fixed).Contributions in progress
Roles performed
N/A
The text was updated successfully, but these errors were encountered: