Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 7 (Deferred) #409

Closed
niyid opened this issue Nov 11, 2019 · 6 comments
Closed

For Cycle 7 (Deferred) #409

niyid opened this issue Nov 11, 2019 · 6 comments

Comments

@niyid
Copy link

niyid commented Nov 11, 2019

## Summary

Specify the total amount of BSQ you are requesting:

  • BSQ requested:

2000 BSQ

Contributions delivered

Provide links to contributions you have delivered, the amount of BSQ you are requesting for each, and any comments that will help stakeholders understand its value.

Contributions in progress

Provide links to work you're involved with that is still in progress. This section is optional, and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same.

  1. Migrated The XMR Integration Incubator to Protocol v1.2. This had an impact on the trading views as expected and of course the expected timelines.
  2. Created a diverged replica of the previously existing trade views for XMR. These will later converge in areas where there are commonalities.

Roles performed

Provide links to your monthly report on any roles you are responsible for.

N/A

@ripcurlx
Copy link
Contributor

ripcurlx commented Nov 13, 2019

Is this work already delivered? Merged in master? I think both were in an open PR I reviewed yesterday.

This work is delivered and merged into master.

@niyid
Copy link
Author

niyid commented Nov 13, 2019

From this comment

utACK

Still need ack from @ManfredKarrer for changes in DAO code to be able to merge

I was under the impression that merging was a foregone conclusion. Apologies if this was a wrong conclusion.

@chimp1984
Copy link

Still need ack from @ManfredKarrer for changes in DAO code to be able to merge

This only applies to code in the dao package in core not in Desktop.

@chimp1984
Copy link

chimp1984 commented Nov 14, 2019

@niyid I don't see the merged PRs, only the issues. Feel free to make your compensation request again next months with listing merged PRs only. I support your contribution but that request seems to not follow our rules.

@niyid
Copy link
Author

niyid commented Nov 14, 2019 via email

@niyid niyid changed the title For Cycle 7 For Cycle 7 (Deferred) Nov 14, 2019
@niyid niyid closed this as completed Nov 14, 2019
@chimp1984
Copy link

Thanks for your understanding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants