Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add and rename Portfolio History columns meaningfully #3338

Closed
huey735 opened this issue Sep 27, 2019 · 4 comments
Closed

Add and rename Portfolio History columns meaningfully #3338

huey735 opened this issue Sep 27, 2019 · 4 comments
Labels
in:gui was:dropped

Comments

@huey735
Copy link
Contributor

huey735 commented Sep 27, 2019 •
edited
Loading

  • Rename "Transaction Fee" column to "Taker trading fee"
  • Rename "Maker Fee" column to "Maker trading fee"
  • Add maker or taker position of the local trader to "Offer type" column
  • Add mining fees columns, named "Maker mining fee" and "Taker mining fee"

How the table looks currently

exportedhistory

Related to #2106

@sqrrm @niyid @wiz
@niyid
Copy link
Contributor

niyid commented Sep 27, 2019 •
edited
Loading

@huey735

Noted. Will do.

@niyid niyid mentioned this issue Sep 28, 2019
Closed
@niyid niyid mentioned this issue Oct 9, 2019
Closed
@niyid niyid mentioned this issue Nov 11, 2019
Closed
This was referenced Dec 12, 2019
Closed
Closed
@niyid niyid mentioned this issue Jan 4, 2020
Closed
@stale
Copy link

stale bot commented Jan 29, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the was:dropped label Jan 29, 2020
@stale
Copy link

stale bot commented Feb 5, 2020

This issue has been automatically closed because of inactivity. Feel free to reopen it if you think it is still relevant.

@stale stale bot closed this as completed Feb 5, 2020
@huey735
Copy link
Contributor Author

huey735 commented Feb 5, 2020

Still relevant.

@niyid niyid mentioned this issue Apr 21, 2020
Closed
@niyid niyid mentioned this issue May 6, 2020
Closed
@niyid niyid mentioned this issue Aug 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in:gui was:dropped
Projects
None yet
Milestone
No milestone
3 participants
@freimair @niyid @huey735