Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 6 #379

Closed
niyid opened this issue Oct 9, 2019 · 5 comments
Closed

For Cycle 6 #379

niyid opened this issue Oct 9, 2019 · 5 comments

Comments

@niyid
Copy link

niyid commented Oct 9, 2019

Summary

Specify the total amount of BSQ you are requesting:

  • BSQ requested:
    BSQ 6750.00

Contributions delivered

Provide links to contributions you have delivered, the amount of BSQ you are requesting for each, and any comments that will help stakeholders understand its value.

The delivery is wrapped as Proposal 110 which combines the following:

This delivery is now patterned as an incubation project as proposed in Proposal 122 to circumvent the issue of a lengthy code review.

The Monero implementation proposals have been a sore point for a long time as Monero trading as a category has the highest trade volume. It is therefore imperative to deliver on proposals (requests) from the group who may feel alienated despite being the major users and therefore contributors in terms of activity. This proposal is an effort to satisfy the Monero traders and not disenfranchise (by ignoring their requests) the majority of Bisq users who happen to trade Monero.

The current delivery is in the Monero Integration Incubation Repository

While the delivery is not in the main branch of Bisq, it is to all intents and purposes shipped code in the same sense as an alpha, beta or variant version of a software.

Not to make this a full blown campaign manifesto, but I believe it is necessary that the incubator projects are incentivized especially in the inception stage as it currently is (and not simply from the selfish point of view but to provide) for a vibrant incubator ecosystem to develop; without which the bureaucracy which it intends to eliminate will creep in and render the process ineffective.

The following is a breakdown spread across the total estimated cost so far:

  1. Proposal - value add (> 90% of trading volume in XMR) - BSQ 950.00
  2. Pluggable Architectural & UI design - BSQ 1150.00
  3. Basic XMR Wallet - BSQ 4650.00
    1. Settings allowing wallet function to be turned off/on. - BSQ 150.00
    2. Settings parameters for connection to monero-wallet-rpc. - BSQ 300.00
    1. Viewing balance (total and unlocked). - BSQ 900.00
    2. Sending XMR. - BSQ 950.00
    3. Viewing XMR Primary address to receive XMR. - BSQ 850
    4. Viewing and searching transactions. - BSQ 850.00
    5. Transaction/payment proof/verification. - BSQ 650.00

Total: BSQ 6750.00

Contributions in progress

Provide links to work you're involved with that is still in progress. This section is optional, and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same.

Proposal 110 Continuation

  1. Completion of automation of Monero related trades (integration to wallet).
  2. Unit Tests (first order - XmrFormatter and XmrValidator).
  3. Payment proof testing completion.

Issues Resolved & PR Pushed

  1. Show reputation balance in BSQ wallet stats bisq#3352
  2. Show BSQ trade fee in % per day bisq#3292
  3. Add and rename Portfolio History columns meaningfully bisq#3338
  4. [Feature] Provide a way to show burned BSQ in a specific timeframe bisq#3303
  5. Arbitration Request - Message Popup bisq#3328
  6. Trade Info Popup bisq#3317
  7. [UI] Increase "Proposals of current cycle" table size to fit the window bisq#3229
  8. Table view columns should use a numeric-sort algorithm bisq#3231

Roles performed

Provide links to your monthly report on any roles you are responsible for.

@sqrrm
Copy link
Member

sqrrm commented Oct 13, 2019

None of these PRs are merged in master. I know incubator is new so I'll give it a pass for this month but I think we need a better way to handle the incubator compensation. I think that was mentioned elsewhere as well.

@niyid
Copy link
Author

niyid commented Oct 13, 2019

None of these PRs are merged in master. I know incubator is new so I'll give it a pass for this month but I think we need a better way to handle the incubator compensation. I think that was mentioned elsewhere as well.

I appreciate the gesture. Yes, @m52go made some suggestions here: Proposal by @m52go. I think this should be formalized as a proposal.

Regards.

@ripcurlx
Copy link
Contributor

As none of these PRs got merged into master and we haven't came to a final decision how the incubation project should be compensated I voted against this compensation request. I don't mean that incubation projects shouldn't be compensated at all, but I think we need to discuss this first to set the right incentives for the future.

@niyid
Copy link
Author

niyid commented Oct 14, 2019

As none of these PRs got merged into master and we haven't came to a final decision how the incubation project should be compensated I voted against this compensation request. I don't mean that incubation projects shouldn't be compensated at all, but I think we need to discuss this first to set the right incentives for the future.

Your candid assessment is appreciated.

@MwithM
Copy link
Contributor

MwithM commented Oct 18, 2019

Closed as accepted.

@MwithM MwithM closed this as completed Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants