-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reputation BSQ added to BSQ Wallet screen #3366
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NACK - if my interpretation is correct.
desktop/src/main/java/bisq/desktop/main/dao/wallet/BsqBalanceUtil.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not happy with the term "Reputation/Weight Balance". I myself (as an active bisq dev) do not understand what the value is about. Furthermore, one might misunderstand this value for riches available.
A few additional words that might clear things up:
- "base balance"
- "base merit"
- "base vote weight"
- "base vote weight (without stake)"
- "for future voting cycles"
- "for next voting cycle"
and we should align the wording here https://docs.bisq.network/dao/overview.html#reputation-based-voting
@m52go may we have your opinion
OK. I am still waiting on the consensus on what term to use. @m52go @freimair I think we should involve much more people on this discussion. |
How about something like: "Reputation Value (not spendable)" OR "Reputation Value (more details 🔗)" If it's possible, I think the second option with a link to the current doc is better. There, this value is called "reputation value" and explains what it is and how it works. I agree with freimair that calling this quantity a balance is confusing, because it's not spendable. |
In that case, Please refer to the related #3352. |
Oh ok, I didn't see that conversation. The doc I referred to is the most up-to-date one, so I guess that needs to be updated. As for my suggestions, simply replace "Reputation" with "Merit". |
I already have it as this:
@freimair is this OK with you? Once again, please refer to related issue #3352 and the suggestion by @chimp1984. |
I'm still seeing this In any case, I would strongly recommend adding some clarification text in parenthesis as suggested above. Either explicitly say it's not spendable or link to more information. Concretely: "Merit Value (not spendable)" OR "Merit Value (more details 🔗)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NACK
desktop/src/main/java/bisq/desktop/main/dao/wallet/BsqBalanceUtil.java
Outdated
Show resolved
Hide resolved
desktop/src/main/java/bisq/desktop/main/dao/wallet/BsqBalanceUtil.java
Outdated
Show resolved
Hide resolved
desktop/src/main/java/bisq/desktop/main/dao/wallet/tx/BsqTxListItem.java
Outdated
Show resolved
Hide resolved
@sqrrm
All fixed. Thanks.
…On Tue, Nov 5, 2019 at 4:50 PM sqrrm ***@***.***> wrote:
***@***.**** requested changes on this pull request.
NACK
------------------------------
In desktop/src/main/java/bisq/desktop/main/dao/wallet/BsqBalanceUtil.java
<#3366 (comment)>:
> @@ -62,10 +72,11 @@
@Inject
private BsqBalanceUtil(BsqWalletService bsqWalletService,
DaoStateService daoStateService,
- BsqFormatter bsqFormatter) {
+ BsqFormatter bsqFormatter, MyBlindVoteListService myBlindVoteListService) {
Please follow local formatting, either line break at each argument or fit
as many arguments as possible before line break.
------------------------------
In desktop/src/main/java/bisq/desktop/main/dao/wallet/BsqBalanceUtil.java
<#3366 (comment)>:
> @@ -18,11 +18,14 @@
package bisq.desktop.main.dao.wallet;
import bisq.desktop.components.TitledGroupBg;
+import bisq.desktop.main.dao.wallet.tx.BsqTxListItem;
Remove unused imports
------------------------------
In
desktop/src/main/java/bisq/desktop/main/dao/wallet/tx/BsqTxListItem.java
<#3366 (comment)>:
> @@ -42,7 +42,7 @@
@slf4j
@EqualsAndHashCode(callSuper = true)
@DaTa
-class BsqTxListItem extends TxConfidenceListItem {
+public class BsqTxListItem extends TxConfidenceListItem {
Don't change access for no reason
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3366?email_source=notifications&email_token=AE2MWR5FH4VPFG7KB2OI4GTQSGI4ZA5CNFSM4I5476X2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCKKZ5AI#pullrequestreview-311795329>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE2MWR4KQ4GPOSDJBZJ7BFDQSGI4ZANCNFSM4I5476XQ>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack. We should squash this contribution because there is quite a lot of commits and merges and stuff.
@niyid stuff we observed with your contributions:
- please keep the commit history clean (make yourself familiar with eg.
git rebase --onto
,git add -p
- please stick to the given code style (in intellij idea: Menu [Code]->[Reformat Code])
- please only commit stuff that has something to do with the topic of the PR (no import, field definition reorgs, ...)
Noted. Thanks. I have squashed the commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Still need ack from @ManfredKarrer for changes in DAO code to be able to merge
desktop/src/main/java/bisq/desktop/main/dao/wallet/BsqBalanceUtil.java
Outdated
Show resolved
Hide resolved
This only applies to code in the dao package in core not in Desktop. |
Thanks for your clarification. I was a bit confused as I did not touch any
DAO code.
Regards.
…On Thu, 14 Nov 2019, 01:01 chimp1984, ***@***.***> wrote:
Still need ack from @ManfredKarrer <https://github.com/ManfredKarrer> for
changes in DAO code to be able to merge
This only applies to code in the dao package in core not in Desktop.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3366?email_source=notifications&email_token=AE2MWR7NICICSB2KEDUJNBDQTSINDA5CNFSM4I5476X2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEADGBY#issuecomment-553661191>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE2MWRY7V62LZVDKFO7H76TQTSINDANCNFSM4I5476XQ>
.
|
Maybe the easiest thing would be to squash your commits into one as the last ones also doesn't fulfill https://chris.beams.io/posts/git-commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NACK - the formatting in BsqBalanceUtil line 132 is not correct. Please use our formatting rules and also it would be great if you could just fork the bisq repository regularly and allow edits by maintainers. If it would have been like that I'd push the formatting fix myself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NACK - please see my comments
desktop/src/main/java/bisq/desktop/main/dao/wallet/BsqBalanceUtil.java
Outdated
Show resolved
Hide resolved
desktop/src/main/java/bisq/desktop/main/dao/wallet/BsqBalanceUtil.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
Issue #3352 resolved.
closes #3352