Fix TradeWizardPriceController throwing exception
#1755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Price controller was throwing an exception upon percentage validation. It worked well while creating offers in one market, but when switching markets and creating a new offer it failed since it was using the previous quote price. Thus, this resets the missing fields every time we use the TradeWizzard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1750
Price controller was throwing an exception upon percentage validation:
bisq2/offer/src/main/java/bisq/offer/price/spec/FloatPriceSpec.java
Line 48 in 5ce2811
It worked well while creating offers in one market, but when switching
markets and creating a new offer it failed since it was using the
previous quote price. Thus, this resets the missing fields every time
we use the
TradeWizard.