Merge pull request #1755 from axpoems/fix-trade-wizard-price

Fix `TradeWizardPriceController` throwing exception
bisq-network · Mar 11, 2024 · aff2aab · aff2aab
2 parents 5edacfa + e465192
commit aff2aab
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 27 deletions.
diff --git a/...ktop/desktop/src/main/java/bisq/desktop/main/content/bisq_easy/components/PriceInput.java b/...ktop/desktop/src/main/java/bisq/desktop/main/content/bisq_easy/components/PriceInput.java
@@ -195,6 +195,7 @@ private Model() {
 
         public void reset() {
             priceQuote.set(null);
+            priceString.set(null);
             market = null;
             isFocused = false;
             description.set(null);

diff --git a/...va/bisq/desktop/main/content/bisq_easy/trade_wizard/price/TradeWizardPriceController.java b/...va/bisq/desktop/main/content/bisq_easy/trade_wizard/price/TradeWizardPriceController.java
@@ -72,6 +72,7 @@ public ReadOnlyObjectProperty<PriceSpec> getPriceSpec() {
     }
 
     public void reset() {
+        priceInput.reset();
         model.reset();
     }
 
@@ -164,18 +165,15 @@ private void applyPercentageFromQuote(PriceQuote priceQuote) {
         model.getPercentageAsString().set(formatToPercentWithSymbol(percentage));
     }
 
-
     //todo add validator and give feedback
     private boolean isQuoteValid(PriceQuote priceQuote) {
         double percentage = getPercentage(priceQuote);
-        if (percentage >= -0.1 && percentage <= 0.5) {
-            return true;
-        }
-        return false;
+        return percentage >= -0.1 && percentage <= 0.5;
     }
 
     private double getPercentage(PriceQuote priceQuote) {
-        Optional<Double> optionalPercentage = PriceSpecUtil.createFloatPriceSpec(marketPriceService, priceQuote).map(FloatPriceSpec::getPercentage);
+        Optional<Double> optionalPercentage = PriceSpecUtil.createFloatPriceSpec(marketPriceService, priceQuote)
+                .map(FloatPriceSpec::getPercentage);
         if (optionalPercentage.isEmpty()) {
             log.error("optionalPercentage not present");
         }

diff --git a/...ain/java/bisq/desktop/main/content/bisq_easy/trade_wizard/price/TradeWizardPriceView.java b/...ain/java/bisq/desktop/main/content/bisq_easy/trade_wizard/price/TradeWizardPriceView.java
@@ -46,6 +46,7 @@ public class TradeWizardPriceView extends View<VBox, TradeWizardPriceModel, Trad
 
     public TradeWizardPriceView(TradeWizardPriceModel model, TradeWizardPriceController controller, PriceInput priceInput) {
         super(new VBox(10), model, controller);
+
         this.priceInput = priceInput;
 
         root.setAlignment(Pos.TOP_CENTER);
@@ -90,17 +91,10 @@ protected void onViewAttached() {
             Node firstChild = useFixPrice ? priceInput.getRoot() : percentage;
             Node lastChild = useFixPrice ? percentage : priceInput.getRoot();
             fieldsBox.getChildren().addAll(firstChild, lastChild);
-            if (useFixPrice) {
-                percentage.setEditable(false);
-                percentage.deselect();
-                priceInput.setEditable(true);
-                priceInput.requestFocus();
-            } else {
-                priceInput.setEditable(false);
-                priceInput.deselect();
-                percentage.setEditable(true);
-                percentage.requestFocus();
-            }
+            priceInput.setEditable(false);
+            priceInput.deselect();
+            percentage.setEditable(true);
+            percentage.requestFocus();
         });
 
         // Needed to trigger focusOut event on amount components

diff --git a/offer/src/main/java/bisq/offer/price/spec/PriceSpecUtil.java b/offer/src/main/java/bisq/offer/price/spec/PriceSpecUtil.java
@@ -26,21 +26,21 @@
 
 public class PriceSpecUtil {
     public static Optional<FixPriceSpec> findFixPriceSpec(PriceSpec priceSpec) {
-        return priceSpec instanceof FixPriceSpec ?
-                Optional.of((FixPriceSpec) priceSpec) :
-                Optional.empty();
+        return priceSpec instanceof FixPriceSpec
+                ? Optional.of((FixPriceSpec) priceSpec)
+                : Optional.empty();
     }
 
     public static Optional<FloatPriceSpec> findFloatPriceSpec(PriceSpec priceSpec) {
-        return priceSpec instanceof FloatPriceSpec ?
-                Optional.of((FloatPriceSpec) priceSpec) :
-                Optional.empty();
+        return priceSpec instanceof FloatPriceSpec
+                ? Optional.of((FloatPriceSpec) priceSpec)
+                : Optional.empty();
     }
 
     public static Optional<MarketPriceSpec> findMarketPriceSpec(PriceSpec priceSpec) {
-        return priceSpec instanceof MarketPriceSpec ?
-                Optional.of((MarketPriceSpec) priceSpec) :
-                Optional.empty();
+        return priceSpec instanceof MarketPriceSpec
+                ? Optional.of((MarketPriceSpec) priceSpec)
+                : Optional.empty();
     }
 
     public static Optional<FloatPriceSpec> createFloatPriceSpec(MarketPriceService marketPriceService, PriceQuote priceQuote) {
@@ -53,4 +53,4 @@ public static Optional<FloatPriceSpec> createFloatPriceSpec(MarketPriceService m
                 .map(FloatPriceSpec::new)
                 .findAny();
     }
-}
+}