Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow only currencies with price feed when creating offers #1750

Merged

Conversation

DrColver
Copy link
Contributor

@DrColver DrColver commented Mar 7, 2024

Fix #1739

Copy link
Contributor

@axpoems axpoems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still get the error with stack trace when creating an offer:

image

Steps to repro: Select market THB > Create offer > Sell Btc > ... and it fails upon arriving in section Price inside the wizard.
I think we also need to apply this in TradeWizardMarketController, see stack trace:

image

@DrColver
Copy link
Contributor Author

DrColver commented Mar 7, 2024

I couldn't reproduce. Sounds like the price feed might be having troubles.

There is a lot of places where a stack trace is shown if there is an issue with the price. I think it would be better to allow creation of offers even when the price feed doesn't work and handle the price issue separately.

@axpoems
Copy link
Contributor

axpoems commented Mar 9, 2024

I couldn't reproduce. Sounds like the price feed might be having troubles.

There is a lot of places where a stack trace is shown if there is an issue with the price. I think it would be better to allow creation of offers even when the price feed doesn't work and handle the price issue separately.

I looked into this more. It fails every time you create an offer and then switch markets and attempt to create a new one there.
The issue was that the price quote was not being reset property. I added the fix for this in #1755.

Copy link
Contributor

@axpoems axpoems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Copy link
Contributor

@alvasw alvasw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alvasw alvasw merged commit a8c0403 into bisq-network:main Mar 11, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix TradeWizard for markets with no price feed
3 participants