Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing pow check for user profile creation #1711

Conversation

djing-chan
Copy link
Contributor

@djing-chan djing-chan commented Feb 28, 2024

Fix #1693

Based on #1706 and #1703

axpoems and others added 13 commits February 28, 2024 09:14
* Remove prefix in file names and leave only number.
* Remove duplicated empty images.
* Delete a selection of 16 background1.
Use an integer array instead of encoding the data into a long which added limitations and made the code more complicate.
Use SIZE instead of width()/height() methods
Add BucketGenerator
Increase *_COUNT values by 1 (was wrong before to use max index)
@djing-chan djing-chan changed the title Fix missing po w check for user profile creation Fix missing pow check for user profile creation Feb 28, 2024
@djing-chan djing-chan force-pushed the Fix-missing-PoW-check-for-user-profile-creation branch from 7318049 to 02aaeb9 Compare February 28, 2024 12:21
Copy link
Contributor

@alvasw alvasw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alvasw
Copy link
Contributor

alvasw commented Feb 28, 2024

I can't merge this PR due to merge conflicts.

@djing-chan djing-chan force-pushed the Fix-missing-PoW-check-for-user-profile-creation branch from 02aaeb9 to 811457e Compare February 29, 2024 01:21
Copy link
Contributor

@HenrikJannsen HenrikJannsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@djing-chan
Copy link
Contributor Author

@alvasw Should be ok now

Copy link
Contributor

@alvasw alvasw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alvasw alvasw merged commit 3788da4 into bisq-network:main Feb 29, 2024
16 checks passed
@djing-chan djing-chan deleted the Fix-missing-PoW-check-for-user-profile-creation branch February 29, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix missing PoW check for user profile creation
4 participants