Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change difficulty calculation #1703

Merged

Conversation

HenrikJannsen
Copy link
Contributor

@HenrikJannsen HenrikJannsen commented Feb 27, 2024

Fixes #1701

With that change used time for pow creation is in the low ms values and sometimes in the 200-400 ms range. CPU usage is 2-3% on the slow notebook which consumed before that change 10%.

We might need to tune the load factor calculation, but that can be done without requiring network wide update.

Don't use async method as we used a join in the caller.
Improve logs
Copy link
Contributor

@djing-chan djing-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Contributor

@alvasw alvasw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alvasw alvasw merged commit 7285ff4 into bisq-network:main Feb 28, 2024
16 checks passed
@HenrikJannsen HenrikJannsen deleted the change_difficulty_calculation branch February 29, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate high CPU usage when connected with 8-10 peers
3 participants