Bisq avatar improvements #1706
Merged
Bisq avatar improvements #1706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HenrikJannsen
force-pushed
the
bisq-avatar-improvements
branch
from
6122280 to
ff59130
Compare
axpoems
reviewed
Feb 28, 2024
...op/src/main/java/bisq/desktop/overlay/onboarding/create_profile/CreateProfileController.java
Outdated
Show resolved
Hide resolved
|
Changes in the following files cause a merge conflict: |
Use an integer array instead of encoding the data into a long which added limitations and made the code more complicate.
Use SIZE instead of width()/height() methods
Add BucketGenerator Increase *_COUNT values by 1 (was wrong before to use max index)
HenrikJannsen
force-pushed
the
bisq-avatar-improvements
branch
from
a3d3d21 to
18dc6ee
Compare
|
@alvasw Rebased on main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1705
Rebased on current main