Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes "Verify result" to "Check signature" #5209

Merged
merged 1 commit into from
Mar 11, 2021
Merged

Changes "Verify result" to "Check signature" #5209

merged 1 commit into from
Mar 11, 2021

Conversation

JaredBoone
Copy link
Contributor

Fixes #5208

This PR changes the button text in the DisputeView for support.sigCheck.button from "Verify result" to "Check signature"

@boring-cyborg
Copy link

boring-cyborg bot commented Feb 20, 2021

Thanks for opening this pull request!

Please check out our contributor checklist and check if Travis or Codacy found any issues with your PR. Also make sure your commits are signed, and that you applied Bisq's code style and formatting.

A maintainer will add an is:priority label to your PR if it is up for compensation. Please see our Bisq Q1 2020 Update post for more details.

@ripcurlx ripcurlx added this to the v1.6.0 milestone Feb 22, 2021
wallclockbuilder
wallclockbuilder approved these changes Mar 7, 2021
View reviewed changes
Copy link
Contributor

@wallclockbuilder wallclockbuilder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UtAck

ripcurlx
ripcurlx approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx
Copy link
Contributor

ripcurlx commented Mar 9, 2021

@JaredBoone Your commit needs to be signed to be able to merge it into master. Thanks!

@JaredBoone
Copy link
Contributor Author

@ripcurlx I had forgotten to add my public key to github. That's done, so I believe it should work now.

@ripcurlx ripcurlx merged commit 43b8f0a into bisq-network:master Mar 11, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 11, 2021

Awesome work, congrats on your first merged pull request!

@wallclockbuilder wallclockbuilder mentioned this pull request Apr 2, 2021
Closed
@wallclockbuilder wallclockbuilder mentioned this pull request Aug 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallclockbuilder wallclockbuilder wallclockbuilder approved these changes

@ripcurlx ripcurlx ripcurlx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

Change Verify result button text in Dispute View
3 participants
@JaredBoone @ripcurlx @wallclockbuilder