-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For Cycle 23 #818
Comments
InfoRead BSQ amount from summary: 218.8073394 ErrorsERROR: Total USD does not match the sum of line items:
|
InfoRead BSQ amount from summary: 406.6115702 ErrorsIncorrect BSQ rate specified: 1.21, expected: 2.18
|
It says for Cycle 22 in the title. Why is the bot still insisting on the cycle 23 rate? |
I guess its ok. This issue had the same problem but was accepted anyway. |
Current DAO cycle, which its proposal phase will end in a week, is Cycle 23. Even if your job was done at Cycle 22, you should title your tasks as "For Cycle 23" and indicate if it's a past task. |
InfoRead BSQ amount from summary: 406.6115702 ErrorsIncorrect BSQ rate specified: 1.21, expected: 2.18
|
1 similar comment
InfoRead BSQ amount from summary: 406.6115702 ErrorsIncorrect BSQ rate specified: 1.21, expected: 2.18
|
Updated. |
InfoRead BSQ amount from summary: 406.6115702 ErrorsIncorrect BSQ rate specified: 1.21, expected: 2.18
|
@wallclockbuilder Could you please resolve the issues pointed out by the bisq-bot so it can be reviewed? Thanks! |
This is for previous cycle 22. The bot is insisting on cycle 23 rate. I guess its ok. This issue had the same problem but was accepted anyway. |
If all the tasks were for the previous cycle, it would be ok to use 1.21USD. Why didn't you submit this compensation request then? |
The only reason to use an old exchange rate should be that the CR was held back for technical reasons like when there was too much BSQ requested and some contributors had to wait one cycle with their requests to avoid failing the vote due to hitting the max issuance limit. Even in the case of a failed cycle I think it's right to use the current rate. |
It's ok for me to do like this from now on. |
It's ok for me to do like this from now on. |
#523 submitted late and it was approved without any discretionary opinions. Is there any written policy concerning this? |
InfoRead BSQ amount from summary: 406.6115702 ErrorsERROR: Total BSQ does not match the sum of line items:
|
InfoRead BSQ amount from summary: 406.6115702 ErrorsIncorrect BSQ rate specified: 1.21, expected: 2.18
|
Updated rate to cycle 23 rate(2.18) as requested. |
New contributors often lack the domain knowledge to provide valuable code reviews. Advice: accept constructive criticism & persevere. Improve your contributions. |
@MwithM. Noticed you moved this to "closed" earlier. Its ready for review now. Please move it to back to "in review". |
@wallclockbuilder I clicked the close issue button by mistake, and then reopened it afterwards. I did not realize that by doing that, the issue stayed as Closed as not submitted. |
Summary(Previous Cycle 22)
225.69
Contributions delivered
The text was updated successfully, but these errors were encountered: