Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Verify result button text in Dispute View #5208

Closed
JaredBoone opened this issue Feb 20, 2021 · 2 comments · Fixed by #5209
Closed

Change Verify result button text in Dispute View #5208

JaredBoone opened this issue Feb 20, 2021 · 2 comments · Fixed by #5209

Comments

@JaredBoone
Copy link
Contributor

Description

The"Verify result" button in the Dispute View is unclear and problematic. The button is intended for checking the signature of the mediator or arbitrator and the button text should reflect that. "Verify result" implies that pushing the button will confirm the result of the dispute. In my opinion the text for this button should be changed. I suggest "View signature", "Inspect signature" or "Check signature".

Version

v1.5.6

Steps to reproduce

  • Open the Dispute View
  • See the "Verify result" button
  • Don't push it because it's too scary

Expected behaviour

  • Open the Dispute View
  • See the "Check signature" button
  • Push it with confidence

Additional info

/core/src/main/resources/i18n/displayString.properties
support.sigCheck.button=Verify result

@boring-cyborg
Copy link

boring-cyborg bot commented Feb 20, 2021

Thanks for opening your first issue here!

Be sure to follow the issue template. Your issue will be reviewed by a maintainer and labeled for further action.

JaredBoone added a commit to JaredBoone/bisq that referenced this issue Feb 20, 2021
JaredBoone added a commit to JaredBoone/bisq that referenced this issue Feb 20, 2021
@Conza88
Copy link

Conza88 commented Feb 20, 2021

I assumed that's what it'd be as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants