fix(configuration): lint rules options are optional #4160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Linter
ematipico
commented
Oct 2, 2024
crates/biome_js_analyze/src/lint/nursery/use_consistent_member_accessibility.rs
Outdated
Show resolved
Hide resolved
arendjr
approved these changes
Oct 2, 2024
Conaclos
reviewed
Oct 2, 2024
crates/biome_js_analyze/src/lint/style/use_filenaming_convention.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/style/use_naming_convention.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/suspicious/no_double_equals.rs
Outdated
Show resolved
Hide resolved
CodSpeed Performance ReportMerging #4160 will not alter performanceComparing Summary
|
Conaclos
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up of #4138
It turns out that the contributing guide was wrong and caused many inconsistencies in our JSON schema.
This PR should fix all the options for lint rules.
Test Plan
I manually checked that the options are now marked as optional in the
configuration_schema.json