fix(configuration): lint rules options are optional

CHANGELOG.md

@@ -9,6 +9,28 @@ New entries must be placed in a section entitled `Unreleased`.
 Read
 our [guidelines for writing a good changelog entry](https://github.com/biomejs/biome/blob/main/CONTRIBUTING.md#changelog).
 
+## Unreleased
+
+### Analyzer
+
+### CLI
+
+### Configuration
+
+#### Bug fixes
+
+- Fix an issue where the JSON schema marked lint rules options as mandatory. Contributed by @ematipico
+
+### Editors
+
+### Formatter
+
+### JavaScript APIs
+
+### Linter
+
+### Parser
+
 ## v1.9.3 (2024-10-01)
 
 ### CLI

crates/biome_js_analyze/src/lint/a11y/no_blank_target.rs

@@ -221,7 +221,7 @@ impl Rule for NoBlankTarget {
 
 #[derive(Clone, Debug, Default, Deserialize, Deserializable, Eq, PartialEq, Serialize)]
 #[cfg_attr(feature = "schema", derive(schemars::JsonSchema))]
-#[serde(rename_all = "camelCase", deny_unknown_fields)]
+#[serde(rename_all = "camelCase", deny_unknown_fields, default)]
 pub struct AllowDomainOptions {
     #[serde(skip_serializing_if = "Vec::is_empty")]
     /// List of domains to allow `target="_blank"` without `rel="noreferrer"`

crates/biome_js_analyze/src/lint/a11y/use_valid_aria_role.rs

@@ -76,7 +76,7 @@ declare_lint_rule! {
 
 #[derive(Clone, Debug, Default, Deserialize, Deserializable, Eq, PartialEq, Serialize)]
 #[cfg_attr(feature = "schema", derive(schemars::JsonSchema))]
-#[serde(rename_all = "camelCase", deny_unknown_fields)]
+#[serde(rename_all = "camelCase", deny_unknown_fields, default)]
 pub struct ValidAriaRoleOptions {
     pub allow_invalid_roles: Vec<String>,
     pub ignore_non_dom: bool,

crates/biome_js_analyze/src/lint/complexity/no_excessive_cognitive_complexity.rs

@@ -370,7 +370,7 @@ pub struct ComplexityScore {
 /// Options for the rule `noExcessiveCognitiveComplexity`.
 #[derive(Clone, Debug, Deserialize, Deserializable, Eq, PartialEq, Serialize)]
 #[cfg_attr(feature = "schema", derive(JsonSchema))]
-#[serde(rename_all = "camelCase", deny_unknown_fields)]
+#[serde(rename_all = "camelCase", deny_unknown_fields, default)]
 pub struct ComplexityOptions {
     /// The maximum complexity score that we allow. Anything higher is considered excessive.
     pub max_allowed_complexity: NonZeroU8,

crates/biome_js_analyze/src/lint/correctness/use_exhaustive_dependencies.rs

@@ -291,7 +291,7 @@ impl Default for HookConfigMaps {
 /// Options for the rule `useExhaustiveDependencies`
 #[derive(Clone, Debug, Deserialize, Deserializable, Eq, PartialEq, Serialize)]
 #[cfg_attr(feature = "schemars", derive(JsonSchema))]
-#[serde(rename_all = "camelCase", deny_unknown_fields)]
+#[serde(rename_all = "camelCase", deny_unknown_fields, default)]
 pub struct UseExhaustiveDependenciesOptions {
     /// Whether to report an error when a dependency is listed in the dependencies array but isn't used. Defaults to true.
     #[serde(default = "report_unnecessary_dependencies_default")]
@@ -318,7 +318,7 @@ fn report_unnecessary_dependencies_default() -> bool {
 
 #[derive(Clone, Debug, Default, Deserialize, Deserializable, Eq, PartialEq, Serialize)]
 #[cfg_attr(feature = "schemars", derive(JsonSchema))]
-#[serde(rename_all = "camelCase", deny_unknown_fields)]
+#[serde(rename_all = "camelCase", deny_unknown_fields, default)]
 #[deserializable(with_validator)]
 pub struct Hook {
     /// The name of the hook.

crates/biome_js_analyze/src/lint/correctness/use_hook_at_top_level.rs

@@ -553,7 +553,7 @@ impl Rule for UseHookAtTopLevel {
 /// hook.
 #[derive(Default, Deserialize, Serialize, Eq, PartialEq, Debug, Clone)]
 #[cfg_attr(feature = "schemars", derive(JsonSchema))]
-#[serde(rename_all = "camelCase", deny_unknown_fields)]
+#[serde(rename_all = "camelCase", deny_unknown_fields, default)]
 pub struct DeprecatedHooksOptions {}
 
 impl Deserializable for DeprecatedHooksOptions {

crates/biome_js_analyze/src/lint/correctness/use_import_extensions.rs

@@ -126,7 +126,7 @@ declare_lint_rule! {
 
 #[derive(Clone, Debug, Default, Deserializable, Deserialize, Serialize, Eq, PartialEq)]
 #[cfg_attr(feature = "schemars", derive(JsonSchema))]
-#[serde(rename_all = "camelCase", deny_unknown_fields)]
+#[serde(rename_all = "camelCase", deny_unknown_fields, default)]
 pub struct UseImportExtensionsOptions {
     /// A map of custom import extension mappings, where the key is the inspected file extension,
     /// and the value is a pair of `module` extension and `component` import extension
@@ -135,7 +135,7 @@ pub struct UseImportExtensionsOptions {
 
 #[derive(Debug, Clone, Default, Deserializable, Deserialize, Serialize, Eq, PartialEq)]
 #[cfg_attr(feature = "schema", derive(schemars::JsonSchema))]
-#[serde(rename_all = "camelCase", deny_unknown_fields)]
+#[serde(rename_all = "camelCase", deny_unknown_fields, default)]
 pub struct SuggestedExtensionMapping {
     /// Extension that should be used for module imports
     pub module: String,

crates/biome_js_analyze/src/lint/nursery/no_restricted_imports.rs

@@ -39,7 +39,7 @@ declare_lint_rule! {
 /// Options for the rule `noRestrictedImports`.
 #[derive(Clone, Debug, Default, Deserialize, Deserializable, Eq, PartialEq, Serialize)]
 #[cfg_attr(feature = "schema", derive(schemars::JsonSchema))]
-#[serde(rename_all = "camelCase", deny_unknown_fields)]
+#[serde(rename_all = "camelCase", deny_unknown_fields, default)]
 pub struct RestrictedImportsOptions {
     /// A list of names that should trigger the rule
     #[serde(skip_serializing_if = "FxHashMap::is_empty")]

crates/biome_js_analyze/src/lint/nursery/no_restricted_types.rs

@@ -124,7 +124,7 @@ impl Rule for NoRestrictedTypes {
     PartialEq,
 )]
 #[cfg_attr(feature = "schemars", derive(JsonSchema))]
-#[serde(rename_all = "camelCase", deny_unknown_fields)]
+#[serde(rename_all = "camelCase", deny_unknown_fields, default)]
 pub struct NoRestrictedTypesOptions {
     types: FxHashMap<String, CustomRestrictedType>,
 }
@@ -140,7 +140,7 @@ pub struct NoRestrictedTypesOptions {
     PartialEq,
 )]
 #[cfg_attr(feature = "schema", derive(schemars::JsonSchema))]
-#[serde(rename_all = "camelCase", deny_unknown_fields)]
+#[serde(rename_all = "camelCase", deny_unknown_fields, default)]
 pub struct CustomRestrictedTypeOptions {
     message: String,
     #[serde(rename = "use")]

crates/biome_js_analyze/src/lint/nursery/use_component_export_only_modules.rs

@@ -113,7 +113,7 @@ declare_lint_rule! {
 
 #[derive(Debug, Clone, Deserialize, Deserializable, Eq, PartialEq, Serialize, Default)]
 #[cfg_attr(feature = "schemars", derive(schemars::JsonSchema))]
-#[serde(rename_all = "camelCase", deny_unknown_fields)]
+#[serde(rename_all = "camelCase", deny_unknown_fields, default)]
 pub struct UseComponentExportOnlyModulesOptions {
     /// Allows the export of constants. This option is for environments that support it, such as [Vite](https://vitejs.dev/)
     #[serde(default)]

crates/biome_js_analyze/src/lint/nursery/use_consistent_member_accessibility.rs

@@ -225,7 +225,8 @@ declare_lint_rule! {
 #[cfg_attr(feature = "schema", derive(schemars::JsonSchema))]
 #[serde(rename_all = "camelCase", deny_unknown_fields)]
 pub struct ConsistentMemberAccessibilityOptions {
-    pub accessibility: Accessibility,
+    #[serde(skip_serializing_if = "Option::is_none")]
+    pub accessibility: Option<Accessibility>,
 }
 
 #[derive(Clone, Debug, Default, Deserialize, Deserializable, Eq, PartialEq, Serialize)]
@@ -247,7 +248,12 @@ impl Rule for UseConsistentMemberAccessibility {
     fn run(ctx: &RuleContext<Self>) -> Self::Signals {
         let node = ctx.query();
         let accessibility = node.accessibility_modifier();
-        match ctx.options().accessibility {
+        let options = ctx.options();
+        let accessibility_option = match &options.accessibility {
+            None => &Accessibility::default(),
+            Some(option) => option,
+        };
+        match accessibility_option {
             Accessibility::NoPublic => accessibility
                 .filter(|accessibility| accessibility.is_public())
                 .map(|accessibility| accessibility.range()),
@@ -257,7 +263,12 @@ impl Rule for UseConsistentMemberAccessibility {
     }
 
     fn diagnostic(ctx: &RuleContext<Self>, range: &Self::State) -> Option<RuleDiagnostic> {
-        let (diag_msg, note_msg) = match ctx.options().accessibility {
+        let options = ctx.options();
+        let accessibility_option = match &options.accessibility {
+            None => &Accessibility::default(),
+            Some(option) => option,
+        };
+        let (diag_msg, note_msg) = match accessibility_option {
             Accessibility::NoPublic => (
                 markup! {
                     "The "<Emphasis>"public"</Emphasis>" modifier is disallowed."

crates/biome_js_analyze/src/lint/nursery/use_sorted_classes/options.rs

@@ -12,7 +12,7 @@ const CLASS_ATTRIBUTES: [&str; 2] = ["class", "className"];
 
 #[derive(Deserialize, Serialize, Eq, PartialEq, Debug, Clone)]
 #[cfg_attr(feature = "schemars", derive(JsonSchema))]
-#[serde(rename_all = "camelCase", deny_unknown_fields)]
+#[serde(rename_all = "camelCase", deny_unknown_fields, default)]
 pub struct UtilityClassSortingOptions {
     /// Additional attributes that will be sorted.
     #[serde(skip_serializing_if = "Option::is_none")]

crates/biome_js_analyze/src/lint/nursery/use_valid_autocomplete.rs

@@ -137,7 +137,7 @@ const BILLING_AND_SHIPPING_ADDRESS: &[&str; 11] = &[
 
 #[derive(Clone, Debug, Default, Deserialize, Deserializable, Eq, PartialEq, Serialize)]
 #[cfg_attr(feature = "schema", derive(schemars::JsonSchema))]
-#[serde(rename_all = "camelCase", deny_unknown_fields)]
+#[serde(rename_all = "camelCase", deny_unknown_fields, default)]
 pub struct UseValidAutocompleteOptions {
     /// `input` like custom components that should be checked.
     pub input_components: Vec<String>,

crates/biome_js_analyze/src/lint/style/no_restricted_globals.rs

@@ -59,7 +59,7 @@ const RESTRICTED_GLOBALS: [&str; 2] = ["event", "error"];
 /// Options for the rule `noRestrictedGlobals`.
 #[derive(Clone, Debug, Default, Deserialize, Deserializable, Eq, PartialEq, Serialize)]
 #[cfg_attr(feature = "schema", derive(schemars::JsonSchema))]
-#[serde(rename_all = "camelCase", deny_unknown_fields)]
+#[serde(rename_all = "camelCase", deny_unknown_fields, default)]
 pub struct RestrictedGlobalsOptions {
     /// A list of names that should trigger the rule
     #[serde(skip_serializing_if = "Vec::is_empty")]

crates/biome_js_analyze/src/lint/style/use_consistent_array_type.rs

@@ -480,7 +480,7 @@ where
 
 #[derive(Clone, Debug, Default, Deserialize, Deserializable, Eq, PartialEq, Serialize)]
 #[cfg_attr(feature = "schemars", derive(JsonSchema))]
-#[serde(rename_all = "camelCase", deny_unknown_fields)]
+#[serde(rename_all = "camelCase", deny_unknown_fields, default)]
 pub struct ConsistentArrayTypeOptions {
     pub syntax: ConsistentArrayType,
 }

crates/biome_js_analyze/src/lint/style/use_filenaming_convention.rs

@@ -341,7 +341,7 @@ pub enum FileNamingConventionState {
 /// Rule's options.
 #[derive(Clone, Debug, Deserialize, Deserializable, Eq, PartialEq, Serialize)]
 #[cfg_attr(feature = "schemars", derive(JsonSchema))]
-#[serde(rename_all = "camelCase", deny_unknown_fields)]
+#[serde(rename_all = "camelCase", deny_unknown_fields, default)]
 pub struct FilenamingConventionOptions {
     /// If `false`, then consecutive uppercase are allowed in _camel_ and _pascal_ cases.
     /// This does not affect other [Case].

crates/biome_js_analyze/src/lint/style/use_naming_convention.rs

@@ -942,7 +942,7 @@ fn renamable(
 /// Rule's options.
 #[derive(Debug, Clone, Deserializable, Eq, PartialEq, serde::Deserialize, serde::Serialize)]
 #[cfg_attr(feature = "schemars", derive(JsonSchema))]
-#[serde(rename_all = "camelCase", deny_unknown_fields)]
+#[serde(rename_all = "camelCase", deny_unknown_fields, default)]
 pub struct NamingConventionOptions {
     /// If `false`, then consecutive uppercase are allowed in _camel_ and _pascal_ cases.
     /// This does not affect other [Case].

crates/biome_js_analyze/src/lint/suspicious/no_double_equals.rs

@@ -156,7 +156,7 @@ impl Rule for NoDoubleEquals {
 /// Rule's options
 #[derive(Clone, Debug, Deserializable, Eq, PartialEq, serde::Deserialize, serde::Serialize)]
 #[cfg_attr(feature = "schemars", derive(JsonSchema))]
-#[serde(rename_all = "camelCase", deny_unknown_fields)]
+#[serde(rename_all = "camelCase", deny_unknown_fields, default)]
 pub struct NoDoubleEqualsOptions {
     /// If `true`, an exception is made when comparing with `null`, as it's often relied on to check
     /// both for `null` or `undefined`.