Add "leaf sorting"; reorganize side panel a bit #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
think node circles is ok where it is for now
i mean it doesnt work yet, it just kinda screws up the tree but it doesnt crash soooo
so leaf sorting kinda works now! untested but still
was messing with leaf sorting, since two differently-sorted versions of the same layout can take up drastically different parts of the screen
prevents user from clicking on it and it recentering the tree but doing nothing
wasn't ignoring it right. argh! that's why tests are good :3
I actually understand what "index" means inside BPTree now! nice.
not very thorough but better than nothing
|
The following artifacts were built for this PR: empire-biplot.qzv, empire.qzv, empress-tree.qzv |
|
Thanks @fedarko |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Support iTOL-style "leaf sorting" #170: adds leaf sorting, and changes the default way the tree is drawn to use
descendingleaf sorting (analogous to iTOL's default). It looks pretty nice :)Closes Reposition some controls in the side panel #379: the leaf sorting (and, now, ignore lengths) options are now located in the
Layouttab of the side panel.It is probably worth noting that changing the default to use leaf sorting makes basically all of the README screenshots slightly out-of-date ... it might be worth seeing if we can finagle McHelper to recompute the README screenshots for every commit? (For now I don't think it's a big deal, though.)