Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reposition some controls in the side panel #379

Closed
fedarko opened this issue Sep 14, 2020 · 0 comments · Fixed by #394
Closed

Reposition some controls in the side panel #379

fedarko opened this issue Sep 14, 2020 · 0 comments · Fixed by #394
Labels
nice to have

Comments

@fedarko
Copy link
Collaborator

fedarko commented Sep 14, 2020

From discussion with @ElDeveloper this morning: should move "show node circles", "ignore branch lengths," etc. to within the Layout tab. There are probably some other small ways to make things more intuitive, as well.
fedarko added a commit to fedarko/empress that referenced this issue Sep 24, 2020
@fedarko
ENH: Move layout options to layout tab: close biocore#379
50373a8 
think node circles is ok where it is for now
@fedarko fedarko mentioned this issue Sep 25, 2020
Merged
ElDeveloper pushed a commit that referenced this issue Sep 28, 2020
@fedarko
Add "leaf sorting"; reorganize side panel a bit (#394)
6dd1085 
* ENH: Move layout options to layout tab: close #379

think node circles is ok where it is for now

* ENH: initial draft of leaf sorting in js

i mean it doesnt work yet, it just kinda screws up the tree

but it doesnt crash soooo

* BUG: fix child sorting

so leaf sorting kinda works now! untested but still

* ENH: Enable JS leaf sorting (close #170)

* ENH: update leaf sorting desc dynamically

* MNT: temporarily? remove layout avg point cache

was messing with leaf sorting, since two differently-sorted versions
of the same layout can take up drastically different parts of the
screen

* ENH: disable leaf sorting sel for unrooted layout

prevents user from clicking on it and it recentering the tree but
doing nothing

* ENH: Just hide leaf sorting rather than disabling

* DOC/PERF/MNT: cache l.s. results; imprv docs/code

* STY: prettify

* MNT: rm old todo

* DOC/PERF: Document new bptree funcs; speed up desc

* DOC: clean up BPTree.getSortedChildren()

* DOC: clarify postorederLeafSortedNodes docs

* TST: Test postorder leafsorted (basic tests)

* BUG: ignore root during circ layout

wasn't ignoring it right. argh! that's why tests are good :3

* TST: unbreak (most of) the js tests

* STY/TST/DOC: tidy up centerLayoutAvgPoint &fix tst

* STY: prettify layout tests

* DOC/TST: doc & tst LayoutsUtil.getPostOrderNodes()

* TST: expand leaf sorting test

* TST/DOC: Add tests+beef up docs for get*Children

I actually understand what "index" means inside BPTree now! nice.

* STY: prettify

* TST: Add rect layout leaf sorting test

* TST: Test desc leaf sorting via layout also kinda

* STY: prettify

* TST: kinda test leaf sorting for circ layouts

not very thorough but better than nothing

* DOC/BUG: doc some new sp funcs; fix desc text

* DOC: update README barplot sec now that #170 done

* TST: make centerLayoutAvgPt tests use util func

Suggestion c/o @ElDeveloper.

* BUG: add back accidentally-rm'd node circles txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
nice to have
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add "leaf sorting"; reorganize side panel a bit fedarko/empress
1 participant
@fedarko