-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support iTOL-style "leaf sorting" #170
Labels
Comments
Merged
fedarko
added a commit
to fedarko/empress
that referenced
this issue
Sep 24, 2020
fedarko
added a commit
to fedarko/empress
that referenced
this issue
Sep 25, 2020
ElDeveloper
pushed a commit
that referenced
this issue
Sep 28, 2020
* ENH: Move layout options to layout tab: close #379 think node circles is ok where it is for now * ENH: initial draft of leaf sorting in js i mean it doesnt work yet, it just kinda screws up the tree but it doesnt crash soooo * BUG: fix child sorting so leaf sorting kinda works now! untested but still * ENH: Enable JS leaf sorting (close #170) * ENH: update leaf sorting desc dynamically * MNT: temporarily? remove layout avg point cache was messing with leaf sorting, since two differently-sorted versions of the same layout can take up drastically different parts of the screen * ENH: disable leaf sorting sel for unrooted layout prevents user from clicking on it and it recentering the tree but doing nothing * ENH: Just hide leaf sorting rather than disabling * DOC/PERF/MNT: cache l.s. results; imprv docs/code * STY: prettify * MNT: rm old todo * DOC/PERF: Document new bptree funcs; speed up desc * DOC: clean up BPTree.getSortedChildren() * DOC: clarify postorederLeafSortedNodes docs * TST: Test postorder leafsorted (basic tests) * BUG: ignore root during circ layout wasn't ignoring it right. argh! that's why tests are good :3 * TST: unbreak (most of) the js tests * STY/TST/DOC: tidy up centerLayoutAvgPoint &fix tst * STY: prettify layout tests * DOC/TST: doc & tst LayoutsUtil.getPostOrderNodes() * TST: expand leaf sorting test * TST/DOC: Add tests+beef up docs for get*Children I actually understand what "index" means inside BPTree now! nice. * STY: prettify * TST: Add rect layout leaf sorting test * TST: Test desc leaf sorting via layout also kinda * STY: prettify * TST: kinda test leaf sorting for circ layouts not very thorough but better than nothing * DOC/BUG: doc some new sp funcs; fix desc text * DOC: update README barplot sec now that #170 done * TST: make centerLayoutAvgPt tests use util func Suggestion c/o @ElDeveloper. * BUG: add back accidentally-rm'd node circles txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This would sort clades in the rectangular and circular layouts by the number of descendant leaves (see the iTOL docs here). I've seen this strategy used in lots of tree figures in papers, and it looks pretty :), so I assume it would be nice if this was an option. (Would be easiest to implement on the command line, but be useful to have in the browser.)
Currently, Empress doesn't do this kind of sorting -- so the original order of clades in the tree's Newick file is followed.
update: I've implemented this in the
leafsorting
branch of my fork (https://github.com/fedarko/empress/tree/leafsorting). I imagine it would be easiest to revisit this once the current prototype branch is finalized and merged in.The text was updated successfully, but these errors were encountered: