Fix extensionDomain check in ExtensionDomain component #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the `bco` object within the `ExtensionDomain` component. This fix ensures accurate handling of the `extensionDomain` property. - Update check from `"extension_domain" in bco` to `typeof bco.extensionDomain !== "undefined"`. - Remove unnecessary comment from the remove button. These changes improve the reliability and readability of the component. Changes to be committed: modified: client/src/components/builder/extensionDomain.js
…wrong-for-empty-domain
Reeya123
approved these changes
Jul 22, 2024
HadleyKing
deleted the
409-derived-bco-shows-something-went-wrong-for-empty-domain
branch
Reeya123
added a commit
that referenced
this pull request
Jul 25, 2024
* Update README.md (#411) * Update README.md * Added Workflow diagram * Added logo image * fixed script driver not saving (#422) Co-authored-by: tianywan819 <[email protected]> * Embargo saving issue (#426) * fixed script driver not saving * Fixed Embargo Time not saving and prepopulate issue --------- Co-authored-by: tianywan819 <[email protected]> * Correct the logic for checking the existence of `extensionDomain` in the `bco` object within the `ExtensionDomain` component. This fix ensures accurate handling of the `extensionDomain` property. (#427) - Update check from `"extension_domain" in bco` to `typeof bco.extensionDomain !== "undefined"`. - Remove unnecessary comment from the remove button. These changes improve the reliability and readability of the component. Changes to be committed: modified: client/src/components/builder/extensionDomain.js * Contribution doc and related documentations. (#434) * Create Contribute doc * Create Contribute doc * Update CONTRIBUTING.md * Update code_of_conduct.md * Update CONTRIBUTING.md * Update CONTRIBUTING.md * Update CONTRIBUTING.md * Update * Added contribution documents * Update contribution doc * PopUp box on Builder page on how to create bco (#435) --------- Co-authored-by: Reeya Gupta <[email protected]> Co-authored-by: Tianyi Wang <[email protected]> Co-authored-by: tianywan819 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct the logic for checking the existence of
extensionDomainin thebcoobject within theExtensionDomaincomponent. This fix ensures accurate handling of theextensionDomainproperty."extension_domain" in bcototypeof bco.extensionDomain !== "undefined".Changes to be committed:
modified: client/src/components/builder/extensionDomain.js