Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed script driver not saving #422

Merged

Conversation

tiwa1154
Copy link
Contributor

No description provided.

@tiwa1154 tiwa1154 added the bug Something isn't working label Jul 15, 2024
@tiwa1154 tiwa1154 requested a review from Reeya123 July 15, 2024 20:54
@Reeya123 Reeya123 merged commit d6be28f into Development Jul 16, 2024
1 of 3 checks passed
@Reeya123 Reeya123 deleted the Script-Driver-and-Environment-Variables-Saving branch July 16, 2024 06:19
Reeya123 added a commit that referenced this pull request Jul 25, 2024
* Update README.md (#411)

* Update README.md

* Added Workflow diagram

* Added logo image

* fixed script driver not saving (#422)

Co-authored-by: tianywan819 <[email protected]>

* Embargo saving issue (#426)

* fixed script driver not saving

* Fixed Embargo Time not saving and prepopulate issue

---------

Co-authored-by: tianywan819 <[email protected]>

* Correct the logic for checking the existence of `extensionDomain` in the `bco` object within the `ExtensionDomain` component. This fix ensures accurate handling of the `extensionDomain` property. (#427)

- Update check from `"extension_domain" in bco` to `typeof bco.extensionDomain !== "undefined"`.
- Remove unnecessary comment from the remove button.

These changes improve the reliability and readability of the component.

Changes to be committed:
	modified:   client/src/components/builder/extensionDomain.js

* Contribution doc and related documentations. (#434)

* Create Contribute doc

* Create Contribute doc

* Update CONTRIBUTING.md

* Update code_of_conduct.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update

* Added contribution documents

* Update contribution doc

* PopUp box on Builder page on how to create bco (#435)

---------

Co-authored-by: Reeya Gupta <[email protected]>
Co-authored-by: Tianyi Wang <[email protected]>
Co-authored-by: tianywan819 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants