Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extensionDomain check in ExtensionDomain component #427

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Fix extensionDomain check in ExtensionDomain component #427

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e4b615
Correct the logic for checking the existence of `extensionDomain` in …
HadleyKing Jul 19, 2024
df8e009
Merge branch 'Development' into 409-derived-bco-shows-something-went-…
HadleyKing Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions client/src/components/builder/extensionDomain.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ import Tooltip from "@mui/material/Tooltip";
export const ExtensionDomain = ({onSave}) => {
const dispatch = useDispatch();
const bco = useSelector(state => state.bco.data)
let has_extension = "extension_domain" in bco
let has_extension = typeof bco.extensionDomain !== "undefined";
const extensionDomain = has_extension ? bco.extension_domain : [];
const [newSchema, setNewSchema] = React.useState("")

const addExtension = async () => {
dispatch(getExtension({newSchema}))
.unwrap()
Expand Down Expand Up @@ -88,8 +88,6 @@ export const ExtensionDomain = ({onSave}) => {
fullWidth
onClick={() => removeRows(index)}>
<RemoveCircleIcon fontSize="23" />

{/* Remove */}
</Button>
</CardContent>)
}))
Expand Down
Loading