fix: adds v3 ethereum protocol addresses. adds patch to take into acc… #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ount pools that have no reserves
|
Foundry report forge 0.2.0 (66bfd97 2022-12-21T00:03:55.180292692Z)Build loginstalling solc version "0.8.17"
Successfully installed solc 0.8.17
Compiling 24 files with 0.8.17
Solc 0.8.17 finished in 799.50ms
Compiler run successful
| Contract | Size (kB) | Margin (kB) |
|------------------------|-----------|-------------|
| AaveGovernanceV2 | 0.249 | 24.327 |
| AaveMisc | 0.086 | 24.49 |
| AaveV2Avalanche | 0.086 | 24.49 |
| AaveV2Ethereum | 0.086 | 24.49 |
| AaveV2EthereumAMM | 0.086 | 24.49 |
| AaveV2EthereumArc | 0.086 | 24.49 |
| AaveV2Fuji | 0.086 | 24.49 |
| AaveV2Goerli | 0.086 | 24.49 |
| AaveV2Mumbai | 0.086 | 24.49 |
| AaveV2Polygon | 0.086 | 24.49 |
| AaveV3Arbitrum | 0.086 | 24.49 |
| AaveV3ArbitrumGoerli | 0.086 | 24.49 |
| AaveV3Avalanche | 0.086 | 24.49 |
| AaveV3Ethereum | 0.086 | 24.49 |
| AaveV3Fantom | 0.086 | 24.49 |
| AaveV3FantomTestnet | 0.086 | 24.49 |
| AaveV3Fuji | 0.086 | 24.49 |
| AaveV3Goerli | 0.086 | 24.49 |
| AaveV3Harmony | 0.086 | 24.49 |
| AaveV3Mumbai | 0.086 | 24.49 |
| AaveV3Optimism | 0.086 | 24.49 |
| AaveV3OptimismGoerli | 0.086 | 24.49 |
| AaveV3Polygon | 0.086 | 24.49 |
| ConfiguratorInputTypes | 0.086 | 24.49 |
| DataTypes | 0.086 | 24.49 |
| console | 0.086 | 24.49 |
| console2 | 0.086 | 24.49 |
| stdError | 0.713 | 23.863 |
| stdJson | 0.086 | 24.49 |
| stdMath | 0.086 | 24.49 |
| stdStorage | 0.086 | 24.49 |
| stdStorageSafe | 0.086 | 24.49 |Test success 🌈No files changed, compilation skipped
Running 2 tests for src/test/AaveV2Misfits.t.sol:AaveAddressMisfitsTest
[PASS] testArcPoolAdminIsCorrect() (gas: 213)
[PASS] testCollectorControllerIs0Address() (gas: 236)
Test result: ok. 2 passed; 0 failed; finished in 349.00µs
Running 9 tests for src/test/AaveV2Ethereum.t.sol:AaveAddressBookTest
[PASS] testAaveProtocolDataProviderIsCorrect() (gas: 258)
[PASS] testCollectorControllerIsCorrect() (gas: 258)
[PASS] testCollectorIsCorrect() (gas: 280)
[PASS] testEmergencyAdminIsCorrect() (gas: 237)
[PASS] testOracleIsCorrect() (gas: 236)
[PASS] testPoolAddressIsCorrect() (gas: 281)
[PASS] testPoolAddressProviderIsCorrect() (gas: 280)
[PASS] testPoolAdminIsCorrect() (gas: 236)
[PASS] testPoolConfiguratorIsCorrect() (gas: 246)
Test result: ok. 9 passed; 0 failed; finished in 692.90µs
Running 9 tests for src/test/AaveV3Avalanche.t.sol:AaveAddressBookTest
[PASS] testACLAdminIsCorrect() (gas: 281)
[PASS] testACLManagerIsCorrect() (gas: 259)
[PASS] testCollectorControllerIsCorrect() (gas: 280)
[PASS] testCollectorIsCorrect() (gas: 236)
[PASS] testEmissionManagerIsCorrect() (gas: 258)
[PASS] testOracleIsCorrect() (gas: 258)
[PASS] testPoolAddressIsCorrect() (gas: 236)
[PASS] testPoolAddressProviderIsCorrect() (gas: 280)
[PASS] testPoolConfiguratorIsCorrect() (gas: 246)
Test result: ok. 9 passed; 0 failed; finished in 552.90µs |
eboadom
reviewed
Dec 21, 2022
scripts/config.ts
Outdated
| @@ -20,7 +20,7 @@ export enum ChainId { | |||
| } | |||
|
|
|||
| const RPC_PROVIDERS = { | |||
| [ChainId.mainnet]: "https://rpc.flashbots.net", | |||
| [ChainId.mainnet]: 'https://rpc.tenderly.co/fork/1e8e167f-4a45-4ac5-8ce1-4045b07a0faf',//"https://rpc.flashbots.net", | |||
There was a problem hiding this comment.
Which is the rationale of this?
There was a problem hiding this comment.
to get the addresses on the v3.0.1 deployed on tenderly.
eboadom
reviewed
Dec 21, 2022
scripts/config.ts
Outdated
| chainId: ChainId.mainnet, | ||
| addressProvider: "0x2f39d218133AFaB8F2B819B1066c7E434Ad94E9e", | ||
| version: 3, | ||
| // additionalAddresses: { |
There was a problem hiding this comment.
no need added here all the extra addresses that are on deployment but we cant bia rpc right now
eboadom
approved these changes
Dec 21, 2022
sendra
added a commit
that referenced
this pull request
Dec 21, 2022
* fix: add core as library * fix: removed custom interface for rate strategy in favor of aave-v3-core * fix: adds v3 ethereum protocol addresses. adds patch to take into acc… (#49) * fix: adds v3 ethereum protocol addresses. adds patch to take into account pools that have no reserves * fix: added extra addresses * fix: added extra addresses for v3 ethereum * fix: correct checksummed addresses * fix: added draft Co-authored-by: sendra <[email protected]> Co-authored-by: sendra <[email protected]>
sendra
added a commit
that referenced
this pull request
Dec 22, 2022
* fix: add core as library * fix: removed custom interface for rate strategy in favor of aave-v3-core * fix: adds v3 ethereum protocol addresses. adds patch to take into acc… (#49) * fix: adds v3 ethereum protocol addresses. adds patch to take into account pools that have no reserves * fix: added extra addresses * fix: added extra addresses for v3 ethereum * fix: correct checksummed addresses * fix: added draft * fix: added castings and struct for backwards compatibility * forge install: aave-v3-core v1.16.2 * fix: updated lib and toml * fix: removed TokenData as its not usable * fix: removed unneeded remapping Co-authored-by: Lukas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ount pools that have no reserves