Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add core as library #47

Merged
merged 4 commits into from
Dec 21, 2022
Merged

fix: add core as library #47

merged 4 commits into from
Dec 21, 2022

Conversation

sakulstra
Copy link
Collaborator

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2022 •
edited
Loading

Foundry report

forge 0.2.0 (66bfd97 2022-12-21T00:03:55.180292692Z)
Build log 
installing solc version "0.8.17"
Successfully installed solc 0.8.17
Compiling 5 files with 0.8.17
Solc 0.8.17 finished in 1.03s
Compiler run successful
| Contract               | Size (kB) | Margin (kB) |
|------------------------|-----------|-------------|
| AaveGovernanceV2       | 0.249     | 24.327      |
| AaveMisc               | 0.086     | 24.49       |
| AaveV2Avalanche        | 0.086     | 24.49       |
| AaveV2Ethereum         | 0.086     | 24.49       |
| AaveV2EthereumAMM      | 0.086     | 24.49       |
| AaveV2EthereumArc      | 0.086     | 24.49       |
| AaveV2Fuji             | 0.086     | 24.49       |
| AaveV2Goerli           | 0.086     | 24.49       |
| AaveV2Mumbai           | 0.086     | 24.49       |
| AaveV2Polygon          | 0.086     | 24.49       |
| AaveV3Arbitrum         | 0.086     | 24.49       |
| AaveV3ArbitrumGoerli   | 0.086     | 24.49       |
| AaveV3Avalanche        | 0.086     | 24.49       |
| AaveV3EthereumDraft    | 0.086     | 24.49       |
| AaveV3Fantom           | 0.086     | 24.49       |
| AaveV3FantomTestnet    | 0.086     | 24.49       |
| AaveV3Fuji             | 0.086     | 24.49       |
| AaveV3Goerli           | 0.086     | 24.49       |
| AaveV3Harmony          | 0.086     | 24.49       |
| AaveV3Mumbai           | 0.086     | 24.49       |
| AaveV3Optimism         | 0.086     | 24.49       |
| AaveV3OptimismGoerli   | 0.086     | 24.49       |
| AaveV3Polygon          | 0.086     | 24.49       |
| ConfiguratorInputTypes | 0.086     | 24.49       |
| DataTypes              | 0.086     | 24.49       |
| console                | 0.086     | 24.49       |
| console2               | 0.086     | 24.49       |
| stdError               | 0.713     | 23.863      |
| stdJson                | 0.086     | 24.49       |
| stdMath                | 0.086     | 24.49       |
| stdStorage             | 0.086     | 24.49       |
| stdStorageSafe         | 0.086     | 24.49       |
Test success 🌈 
No files changed, compilation skipped

Running 9 tests for src/test/AaveV2Ethereum.t.sol:AaveAddressBookTest
[PASS] testAaveProtocolDataProviderIsCorrect() (gas: 258)
[PASS] testCollectorControllerIsCorrect() (gas: 258)
[PASS] testCollectorIsCorrect() (gas: 280)
[PASS] testEmergencyAdminIsCorrect() (gas: 237)
[PASS] testOracleIsCorrect() (gas: 236)
[PASS] testPoolAddressIsCorrect() (gas: 281)
[PASS] testPoolAddressProviderIsCorrect() (gas: 280)
[PASS] testPoolAdminIsCorrect() (gas: 236)
[PASS] testPoolConfiguratorIsCorrect() (gas: 246)
Test result: ok. 9 passed; 0 failed; finished in 918.00µs

Running 2 tests for src/test/AaveV2Misfits.t.sol:AaveAddressMisfitsTest
[PASS] testArcPoolAdminIsCorrect() (gas: 213)
[PASS] testCollectorControllerIs0Address() (gas: 236)
Test result: ok. 2 passed; 0 failed; finished in 303.90µs

Running 9 tests for src/test/AaveV3Avalanche.t.sol:AaveAddressBookTest
[PASS] testACLAdminIsCorrect() (gas: 281)
[PASS] testACLManagerIsCorrect() (gas: 259)
[PASS] testCollectorControllerIsCorrect() (gas: 280)
[PASS] testCollectorIsCorrect() (gas: 236)
[PASS] testEmissionManagerIsCorrect() (gas: 258)
[PASS] testOracleIsCorrect() (gas: 258)
[PASS] testPoolAddressIsCorrect() (gas: 236)
[PASS] testPoolAddressProviderIsCorrect() (gas: 280)
[PASS] testPoolConfiguratorIsCorrect() (gas: 246)
Test result: ok. 9 passed; 0 failed; finished in 2.83ms

sakulstra
sakulstra commented Dec 9, 2022
View reviewed changes
.gitmodules Outdated
[submodule "lib/aave-v3-core"]
path = lib/aave-v3-core
url = https://github.com/aave/aave-v3-core
branch = fix/738-soften-datatypes-sol-version
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be removed once
aave/aave-v3-core#762 and
aave/aave-v3-core#763 are merged
and v3.0.1 is merged to main on aave-v3-core repo

sakulstra
sakulstra commented Dec 9, 2022
View reviewed changes
src/AaveV3.sol Outdated Show resolved Hide resolved
@sendra sendra force-pushed the feat/add-core-as-lib branch from a7d287a to d1d5fcb Compare December 14, 2022 14:03
sendra and others added 2 commits December 21, 2022 14:39
@sendra
fix: adds v3 ethereum protocol addresses. adds patch to take into acc… (
0972d64 
#49)

* fix: adds v3 ethereum protocol addresses. adds patch to take into account pools that have no reserves

* fix: added extra addresses

* fix: added extra addresses for v3 ethereum

* fix: correct checksummed addresses
@sendra
fix: added draft
255522d
@sendra sendra merged commit 86c7b0e into main Dec 21, 2022
@sendra sendra deleted the feat/add-core-as-lib branch December 21, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eboadom eboadom eboadom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Aave v3.0.1
3 participants
@sakulstra @eboadom @sendra