Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soften solidity version of Datatypes libraries #762

Merged
merged 2 commits into from
Dec 12, 2022

Conversation

miguelmtzinf
Copy link
Contributor

Close #738

@miguelmtzinf
Copy link
Contributor Author

It would be great to count with @eboadom and @kyzia551 feedback on this. I wonder if we should also soften the version of other libraries like:

  • helpers/*
  • math/*

@kyzia551
Copy link
Collaborator

kyzia551 commented Dec 9, 2022

It would be great to count with @eboadom and @kyzia551 feedback on this. I wonder if we should also soften the version of other libraries like:

  • helpers/*
  • math/*

You know my opinion, that we should make it soft everywhere, and you know that auditors do not agree with it :')

@sakulstra
Copy link
Collaborator

For everything that might potentially be used by a 3th party fixed version is annoying.

@eboadom
Copy link
Collaborator

eboadom commented Dec 11, 2022

@miguelmtzinf changed to ^0.8.0 on /math and /helpers, but also on /configuration. It is quite typical for integrators to fetch the uint256 encoded config from the Pool with getConfiguration() and then import and using...for with the ReserveConfigurationMap

@miguelmtzinf
Copy link
Contributor Author

Thanks @kyzia551 @eboadom @sakulstra , I think we found a good balance!

@miguelmtzinf miguelmtzinf merged commit 2b1354b into feat/3.0.1 Dec 12, 2022
@miguelmtzinf miguelmtzinf deleted the fix/738-soften-datatypes-sol-version branch December 12, 2022 12:50
@miguelmtzinf miguelmtzinf mentioned this pull request Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change DataTypes.sol solidity version to ^0.8.0 to support all 0.8.x
4 participants