-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/backwards compatibility #51
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#49) * fix: adds v3 ethereum protocol addresses. adds patch to take into account pools that have no reserves * fix: added extra addresses * fix: added extra addresses for v3 ethereum * fix: correct checksummed addresses
…/backwards-compatibility
Foundry report forge 0.2.0 (8c4294c 2022-12-22T00:03:55.083004205Z) Build loginstalling solc version "0.8.17"
Successfully installed solc 0.8.17
No files changed, compilation skipped
| Contract | Size (kB) | Margin (kB) |
|------------------------|-----------|-------------|
| AaveGovernanceV2 | 0.249 | 24.327 |
| AaveMisc | 0.086 | 24.49 |
| AaveV2Avalanche | 0.086 | 24.49 |
| AaveV2Ethereum | 0.086 | 24.49 |
| AaveV2EthereumAMM | 0.086 | 24.49 |
| AaveV2EthereumArc | 0.086 | 24.49 |
| AaveV2Fuji | 0.086 | 24.49 |
| AaveV2Goerli | 0.086 | 24.49 |
| AaveV2Mumbai | 0.086 | 24.49 |
| AaveV2Polygon | 0.086 | 24.49 |
| AaveV3Arbitrum | 0.086 | 24.49 |
| AaveV3ArbitrumGoerli | 0.086 | 24.49 |
| AaveV3Avalanche | 0.086 | 24.49 |
| AaveV3EthereumDraft | 0.086 | 24.49 |
| AaveV3Fantom | 0.086 | 24.49 |
| AaveV3FantomTestnet | 0.086 | 24.49 |
| AaveV3Fuji | 0.086 | 24.49 |
| AaveV3Goerli | 0.086 | 24.49 |
| AaveV3Harmony | 0.086 | 24.49 |
| AaveV3Mumbai | 0.086 | 24.49 |
| AaveV3Optimism | 0.086 | 24.49 |
| AaveV3OptimismGoerli | 0.086 | 24.49 |
| AaveV3Polygon | 0.086 | 24.49 |
| ConfiguratorInputTypes | 0.086 | 24.49 |
| DataTypes | 0.086 | 24.49 |
| console | 0.086 | 24.49 |
| console2 | 0.086 | 24.49 |
| stdError | 0.713 | 23.863 |
| stdJson | 0.086 | 24.49 |
| stdMath | 0.086 | 24.49 |
| stdStorage | 0.086 | 24.49 |
| stdStorageSafe | 0.086 | 24.49 | Test success 🌈No files changed, compilation skipped
Running 2 tests for src/test/AaveV2Misfits.t.sol:AaveAddressMisfitsTest
[PASS] testArcPoolAdminIsCorrect() (gas: 213)
[PASS] testCollectorControllerIs0Address() (gas: 236)
Test result: ok. 2 passed; 0 failed; finished in 591.00µs
Running 9 tests for src/test/AaveV2Ethereum.t.sol:AaveAddressBookTest
[PASS] testAaveProtocolDataProviderIsCorrect() (gas: 258)
[PASS] testCollectorControllerIsCorrect() (gas: 258)
[PASS] testCollectorIsCorrect() (gas: 280)
[PASS] testEmergencyAdminIsCorrect() (gas: 237)
[PASS] testOracleIsCorrect() (gas: 236)
[PASS] testPoolAddressIsCorrect() (gas: 281)
[PASS] testPoolAddressProviderIsCorrect() (gas: 280)
[PASS] testPoolAdminIsCorrect() (gas: 236)
[PASS] testPoolConfiguratorIsCorrect() (gas: 246)
Test result: ok. 9 passed; 0 failed; finished in 1.14ms
Running 9 tests for src/test/AaveV3Avalanche.t.sol:AaveAddressBookTest
[PASS] testACLAdminIsCorrect() (gas: 281)
[PASS] testACLManagerIsCorrect() (gas: 259)
[PASS] testCollectorControllerIsCorrect() (gas: 280)
[PASS] testCollectorIsCorrect() (gas: 236)
[PASS] testEmissionManagerIsCorrect() (gas: 258)
[PASS] testOracleIsCorrect() (gas: 258)
[PASS] testPoolAddressIsCorrect() (gas: 236)
[PASS] testPoolAddressProviderIsCorrect() (gas: 280)
[PASS] testPoolConfiguratorIsCorrect() (gas: 246)
Test result: ok. 9 passed; 0 failed; finished in 675.30µs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.