Reserved words used as property/function/variable identifiers are formatted incorrectly #368
Labels
Comments
|
@bitwiseman huh...looks like github remembers your last filter state of the issues view page/list and reapplys it when you come back... I was filtered to issues tagged as "discussion" and didn't notice it, so I missed 309 & 351. Sorry about that. Was worried it might be a limitation due to #200. Thanks |
This was referenced Mar 10, 2014
bitwiseman
added a commit
to bitwiseman/js-beautify
that referenced
this issue
Mar 28, 2014
This supports calling libraries which declare properties of objects using reserved words.
This does not support declaring these fields.
`var a = { 'throw': function() {} }` - works
`a.throw()` - works
`var a = { throw: function() {} }` - does not work
Fixes beautifier#309
Fixes beautifier#351
Fixes beautifier#368
Fixes beautifier#378
ledsun
added a commit
to ledsun/jsformat-atom
that referenced
this issue
Jun 23, 2014
Because 'catch' formatting incorrectly for function of name 'catch'. And it is fixed in beautifier/js-beautify#368 .
ledsun
added a commit
to ledsun/jsformat-atom
that referenced
this issue
Jun 23, 2014
Because 'catch' formatting incorrectly for function of name 'catch'. And it is fixed in beautifier/js-beautify#368 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From jdavisclark/JsFormat#89 :
Handlebars.default.compile("hello world");Regardless of how I feel about using keywords as property names, even if it usually works, some APIs do force you in to it, and not everyone likes getting around it with
Handlebars["default"].compile(...)Is this possible or is it one of those instances where it isn't going to happen since the source isn't really getting completely parsed? Somehow I'm still not really familiar with the jsbeautifier codebase...
The text was updated successfully, but these errors were encountered: