Avoid breaking catch/finally on angular promises

[Marsup]

Fixes cases where code like :

$http(...)
  .then(...)
  .catch(...)
  .finally(...)

would end up looking like this :

$http(...)
  .then(...)
  .
  catch(...)
  .
  finally(...)

[bitwiseman]

The current bug for this also includes throw... If you're going to do this it should work for all keywords, not as a special case for these few.

[zaggino]

+1
This also applies to many other codes, not only AngularJS ... most implemntations of http://promisesaplus.com/ use .catch and .finally even native ones:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise
http://www.html5rocks.com/en/tutorials/es6/promises/

[Marsup]

@bitwiseman The throw is now excluded from the scope and python version is done. Should I check around these tokens for context to make sure it's a promise or is it too much ?

[bitwiseman]

See #368. I don't want take this for promises in particular. I want to see it work for any case where a keyword is used as the name of a property or function. You've done great work leveraging the existing structures in your other PRs. This one's a little harder because we want to treat any identifier that comes after . as a "non-keyword".

Since we do a bunch of string compares for keywords... The right thing is to add a flag.keyword, check it in all the places we do checks for keyword strings, and finally force it to false if the previous character is .. It'll be a wide change but a reasonable one.

[bitwiseman]

This is what I'm talking about, although a bit rough...
bitwiseman@46676d2
I'm not in love with this exact implementation, but it is not horrendous. I'll translate to python later tonight.

[Marsup]

Doesn't look rough to me, it actually feels very coherent with the coding style of the project.

[bitwiseman]

Thanks. The change is what I described to you, it is in the right direction, and it is enough. TK_RESERVED still feels hacky to me. 😄

I'm going to close this in favor of mine. Thanks for the push to get this done - it is a heavily requested feature and unblocks us for correct handling of other ES6 and reserved words.

[Marsup]

Well I can't take credit for it but thanks for supporting the effort of moving to an ES6-compatible version :)